Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread docs #38433

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Thread docs #38433

merged 1 commit into from
Dec 19, 2016

Conversation

GuillaumeGomez
Copy link
Member

r? @frewscvx

frewsxcv
frewsxcv approved these changes Dec 17, 2016
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after the link fix

src/libstd/thread/mod.rs
//! * By spawning a new thread, e.g. using the `thread::spawn` function, and
//! calling `thread()` on the `JoinHandle`.
//! * By requesting the current thread, using the `thread::current` function.
//! * By spawning a new thread, e.g. using the [`thread::spawn`][`spawn]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[`thread::spawn`][`spawn]

This looks like a typo.

src/libstd/thread/mod.rs
//! calling `thread()` on the `JoinHandle`.
//! * By requesting the current thread, using the `thread::current` function.
//! * By spawning a new thread, e.g. using the [`thread::spawn`][`spawn]
//! function, and calling [`thread()`] on the [`JoinHandle`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: As per the docs meeting this week, we don't need the () in the function/method display names for links, but we can address all these later in one PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer so if you don't mind.

@GuillaumeGomez
Copy link
Member Author

@bors: r=frewsxcv

@bors
Copy link
Contributor

bors commented Dec 18, 2016

📌 Commit 79e8a70 has been approved by frewsxcv

@frewsxcv
Copy link
Member

@bors rollup

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Dec 19, 2016
@sanxiyn
Rollup merge of rust-lang#38433 - GuillaumeGomez:thread_docs, r=frewsxcv
49cd809 
Thread docs

r? @frewscvx
@sanxiyn sanxiyn mentioned this pull request Dec 19, 2016
Merged
bors added a commit that referenced this pull request Dec 19, 2016
@bors
Auto merge of #38466 - sanxiyn:rollup, r=sanxiyn
10271ea 
Rollup of 9 pull requests

- Successful merges: #38334, #38397, #38413, #38421, #38422, #38433, #38438, #38445, #38459
- Failed merges:
@bors bors merged commit 79e8a70 into rust-lang:master Dec 19, 2016
@GuillaumeGomez GuillaumeGomez deleted the thread_docs branch December 21, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @bors @frewsxcv