Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the API examples for std::fs::File. #38443

Merged
merged 1 commit into from
Dec 24, 2016
Merged

Improve the API examples for std::fs::File. #38443

merged 1 commit into from
Dec 24, 2016

Conversation

frewsxcv
Copy link
Member

Fixes #35875.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv mentioned this pull request Dec 18, 2016
Closed
@frewsxcv
Improve the API examples for std::fs::File.
a664466 
* Separate functionality into different code blocks
* Incorporate `BufReader` example
 * Fixes rust-lang#35875.
@frewsxcv frewsxcv changed the title Rewrite, improve the API examples for std::fs::File. Improve the API examples for std::fs::File. Dec 18, 2016
@frewsxcv
Copy link
Member Author

Should I recommend using BufWriter as well?

@frewsxcv
Copy link
Member Author

@bors delegate=kmcallister

@bors
Copy link
Contributor

bors commented Dec 18, 2016

✌️ @kmcallister can now approve this pull request

@brson
Copy link
Contributor

brson commented Dec 24, 2016

@bors r+ Thanks @frewsxcv.

@bors
Copy link
Contributor

bors commented Dec 24, 2016

📌 Commit a664466 has been approved by brson

@bors
Copy link
Contributor

bors commented Dec 24, 2016

⌛ Testing commit a664466 with merge 00e61d4...

bors added a commit that referenced this pull request Dec 24, 2016
@bors
Auto merge of #38443 - frewsxcv:file-docs, r=brson
00e61d4 
Improve the API examples for `std::fs::File`.

Fixes #35875.
@bors
Copy link
Contributor

bors commented Dec 24, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing 00e61d4 to master...

@bors bors merged commit a664466 into rust-lang:master Dec 24, 2016
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @rust-highfive @bors @brson