Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Update Cargo download location #38470

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

alexcrichton
Copy link
Member

I updated the beta compiler used to bootstrap the master branch in #38438 with
the intention of fixing Travis OSX linkage issues but I mistakenly forgot that
the PR only updated rustc, not Cargo itself. Cargo has a new release process
with downloads in a different location, so this commit updates rustbuild to
download from this new location by tracking revisions instead of Cargo nightly
dates.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Dec 19, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2016

📌 Commit 5b1336a has been approved by brson

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 19, 2016
@brson
Copy link
Contributor

brson commented Dec 19, 2016

Needed for 1.15 beta presumably.

@alexcrichton
Copy link
Member Author

@bors: p=1

needed for a backport, so let's land this sooner rather than later

@bors
Copy link
Contributor

bors commented Dec 19, 2016

⌛ Testing commit 5b1336a with merge 4d3efad...

@bors
Copy link
Contributor

bors commented Dec 19, 2016

💔 Test failed - auto-win-gnu-64-opt

I updated the beta compiler used to bootstrap the master branch in rust-lang#38438 with
the intention of fixing Travis OSX linkage issues but I mistakenly forgot that
the PR only updated rustc, not Cargo itself. Cargo has a new release process
with downloads in a different location, so this commit updates rustbuild to
download from this new location by tracking revisions instead of Cargo nightly
dates.
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Dec 20, 2016

📌 Commit f5e7d92 has been approved by brson

@bors
Copy link
Contributor

bors commented Dec 20, 2016

⌛ Testing commit f5e7d92 with merge 03dd5e5...

@bors
Copy link
Contributor

bors commented Dec 20, 2016

💔 Test failed - auto-win-msvc-32-opt

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 20, 2016
rustbuild: Update Cargo download location

I updated the beta compiler used to bootstrap the master branch in rust-lang#38438 with
the intention of fixing Travis OSX linkage issues but I mistakenly forgot that
the PR only updated rustc, not Cargo itself. Cargo has a new release process
with downloads in a different location, so this commit updates rustbuild to
download from this new location by tracking revisions instead of Cargo nightly
dates.
bors added a commit that referenced this pull request Dec 20, 2016
@brson brson mentioned this pull request Dec 20, 2016
@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 21, 2016

⌛ Testing commit f5e7d92 with merge 164619a...

@bors bors merged commit f5e7d92 into rust-lang:master Dec 21, 2016
@alexcrichton alexcrichton deleted the really-fix-osx branch December 27, 2016 06:15
bors added a commit that referenced this pull request Dec 29, 2016
Bump bootstrap compiler

r? @alexcrichton

I'm not clear on whether cargo will need to additionally be bumped beyond what's in #38470
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 30, 2016
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants