-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify phrasing of MSYS2 dependencies in README.md. #38517
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
# that it is important that the `python2` and `cmake` packages **not** used. | ||
# The build has historically been known to fail with these packages. | ||
# or CMake installed and in PATH you can remove them from this list. Note | ||
# that it is important that you do not use the `python2` and `cmake` packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the bold on "not" removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unintentional. Reverted back.
# The build has historically been known to fail with these packages. | ||
# or CMake installed and in PATH you can remove them from this list. Note | ||
# that it is important that you do not use the `python2` and `cmake` packages | ||
# from the [`msys2` subsystem]. The build has historically been known to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link doesn't seem to work in
code
block (see the preview).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, this is a code block. Removed the link.
215977a
to
efbdcb0
Compare
Comments have been addressed. |
efbdcb0
to
273cc30
Compare
@bors: r+ Thanks! |
📌 Commit 273cc30 has been approved by |
@bors rollup |
…, r=alexcrichton Clarify phrasing of MSYS2 dependencies in README.md. Fixes rust-lang#36115.
Fixes #36115.