Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify phrasing of MSYS2 dependencies in README.md. #38517

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

frewsxcv
Copy link
Member

Fixes #36115.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

# that it is important that the `python2` and `cmake` packages **not** used.
# The build has historically been known to fail with these packages.
# or CMake installed and in PATH you can remove them from this list. Note
# that it is important that you do not use the `python2` and `cmake` packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the bold on "not" removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional. Reverted back.

# The build has historically been known to fail with these packages.
# or CMake installed and in PATH you can remove them from this list. Note
# that it is important that you do not use the `python2` and `cmake` packages
# from the [`msys2` subsystem]. The build has historically been known to fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't seem to work in

code

block (see the preview).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, this is a code block. Removed the link.

@frewsxcv frewsxcv force-pushed the clarify-msys2-dependencies branch 2 times, most recently from 215977a to efbdcb0 Compare December 21, 2016 22:17
@frewsxcv
Copy link
Member Author

Comments have been addressed.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 25, 2016

📌 Commit 273cc30 has been approved by alexcrichton

@frewsxcv
Copy link
Member Author

@bors rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
…, r=alexcrichton

Clarify phrasing of MSYS2 dependencies in README.md.

Fixes rust-lang#36115.
bors added a commit that referenced this pull request Dec 30, 2016
@bors bors merged commit 273cc30 into rust-lang:master Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants