-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE in rustdoc #38537
Fix ICE in rustdoc #38537
Conversation
You shouldn't write in the source tree. (Source tree is mounted read-only on Travis to enforce this.) See #37176. |
357818e
to
1187e21
Compare
@bors: r+ |
📌 Commit 1187e21 has been approved by |
I confirmed this fixes both the minimal repro as well as my original code. Thanks! |
⌛ Testing commit 1187e21 with merge d35f39b... |
💔 Test failed - status-travis |
☀️ Test successful - status-appveyor, status-travis |
Marking as beta-accepted. Small patch, regression. cc @rust-lang/compiler |
Wait, was this a regression @jseyfried ? |
@nikomatsakis It was only a regression with |
That feature is getting stabilized though. |
@eddyb Right, but if we didn't backport it wouldn't technically be a regression from stable to stable. |
OK, since we are stabilizing, let's backport. Marking as beta-accepted. cc @rust-lang/compiler |
This test is failing on 1.21.0 on Debian on amd64 and ppc64el:
Does that |
@infinity0 That's just the warning, the failure looks like broken dynamic linking or something. |
Fixes #38237.
r? @nrc