Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in rustdoc #38537

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Fix ICE in rustdoc #38537

merged 1 commit into from
Dec 27, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #38237.
r? @nrc

@sanxiyn
Copy link
Member

sanxiyn commented Dec 22, 2016

You shouldn't write in the source tree. (Source tree is mounted read-only on Travis to enforce this.) See #37176.

@jseyfried jseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2016
@nrc
Copy link
Member

nrc commented Dec 23, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 23, 2016

📌 Commit 1187e21 has been approved by nrc

@Arnavion
Copy link

I confirmed this fixes both the minimal repro as well as my original code. Thanks!

@bors
Copy link
Contributor

bors commented Dec 26, 2016

⌛ Testing commit 1187e21 with merge d35f39b...

@bors
Copy link
Contributor

bors commented Dec 26, 2016

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors
Copy link
Contributor

bors commented Dec 27, 2016

⌛ Testing commit 1187e21 with merge 9351c2c...

bors added a commit that referenced this pull request Dec 27, 2016
@bors
Copy link
Contributor

bors commented Dec 27, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 9351c2c to master...

@bors bors merged commit 1187e21 into rust-lang:master Dec 27, 2016
@jseyfried jseyfried deleted the fix_rustdoc_ice branch December 27, 2016 08:36
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Small patch, regression. cc @rust-lang/compiler

@nikomatsakis
Copy link
Contributor

Wait, was this a regression @jseyfried ?

@jseyfried
Copy link
Contributor Author

@nikomatsakis It was only a regression with #![feature(proc_macros)]. I still think it would be a good idea to backport though since it's such a small change.

@eddyb
Copy link
Member

eddyb commented Jan 2, 2017

That feature is getting stabilized though.

@jseyfried
Copy link
Contributor Author

@eddyb Right, but if we didn't backport it wouldn't technically be a regression from stable to stable.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 3, 2017
@nikomatsakis
Copy link
Contributor

OK, since we are stabilizing, let's backport. Marking as beta-accepted. cc @rust-lang/compiler

@nikomatsakis nikomatsakis mentioned this pull request Jan 6, 2017
17 tasks
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 6, 2017
@infinity0
Copy link
Contributor

This test is failing on 1.21.0 on Debian on amd64 and ppc64el:

warning: struct is never used: `S`
  --> foo.rs:19:1
   |
19 | struct S;
   | ^^^^^^^^^
   |
   = note: #[warn(dead_code)] on by default

/<<BUILDDIR>>/rustc-1.21.0+dfsg1/build/powerpc64le-unknown-linux-gnu/stage2/bin/rustdoc: error while loading shared libraries: librustc_driver-be990221f14aebfb.so: cannot open shared object file: No such file or directory
make[2]: *** [all] Error 127

Does that struct S need to be a pub struct S?

@eddyb
Copy link
Member

eddyb commented Oct 18, 2017

@infinity0 That's just the warning, the failure looks like broken dynamic linking or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants