Fix rustdoc highlighting of & and *
#38569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespace tokens were included, so the span check used with `&` was incorrect, and it was never highlighted as kw-2. The `*` in `*foo` and `*const T` should also be highlighted kw-2, so I added them. Note that this *will* cause mishighlighting of code like `1*2`, but that should have been written `1 * 2`. Same deal with `1&2`.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
I'm okay with this. @bors: r+ thank you! |
|
We'll need to be careful about this but otherwise, good job! |
|
@bors r=steveklabnik |
|
📌 Commit c9a6e87 has been approved by |
|
⌛ Testing commit c9a6e87 with merge c6f9d55... |
|
💔 Test failed - status-travis |
|
… On Thu, Jan 12, 2017 at 3:39 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/191260197>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38569 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EMPwhrrKsNdkYx1Rt9DAsbw_xqeks5rRhDkgaJpZM4LUnVG>
.
|
bors
added a commit
that referenced
this pull request
Jan 12, 2017
…abnik Fix rustdoc highlighting of `&` and `*` Whitespace tokens were included, so the span check used with `&` was incorrect, and it was never highlighted as kw-2 (RefKeyword). The `*` in `*foo` and `*const T` should also be highlighted kw-2, so I added them. Note that this *will* cause mishighlighting of code like `1*2`, but that should have been written `1 * 2`. Same deal with `1&2`.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace tokens were included, so the span check used with
&was incorrect, and it was never highlighted as kw-2 (RefKeyword).The
*in*fooand*const Tshould also be highlighted kw-2, so I added them. Note that this will cause mishighlighting of code like1*2, but that should have been written1 * 2. Same deal with1&2.