rustbuild: Compile all support tools in stage0 #38667
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is done in preparation for more bullets on #38531. Our cross-host builds are supposed to look like:
That is, when creating a cross-compiled compiler we should only create two compilers. Currently with the way the bootstrap is configured producing documentation for a cross-compiled target requires a host compiler in stage2, which results in an extra compilation of an |
|
☔ The latest upstream changes (presumably #38697) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit changes all tools and such to get compiled in stage0, not in later stages. The purpose of this commit is to cut down dependencies on later stages for future modifications to the build system. Notably we're going to be adding builders that produce a full suite of cross-compiled artifacts for a particular host, and that shouldn't compile the `x86_64-unknown-linux-gnu` compiler more than once. Currently dependencies on, for example, the error index end up compiling the `x86_64-unknown-linux-gnu` compiler more than necessary. As a result here we move many dependencies on these tools to being produced by a stage0 compiler, not a stage1+ compiler. None of these tools actually need to be staged at all, so they'll exhibit consistent behavior across the stages.
alexcrichton
force-pushed
the
stage0-tools
branch
from
80786d8 to
254876e
Compare
|
Rebased |
|
@bors r+ |
|
📌 Commit 254876e has been approved by |
rustbuild: Compile all support tools in stage0 This commit changes all tools and such to get compiled in stage0, not in later stages. The purpose of this commit is to cut down dependencies on later stages for future modifications to the build system. Notably we're going to be adding builders that produce a full suite of cross-compiled artifacts for a particular host, and that shouldn't compile the `x86_64-unknown-linux-gnu` compiler more than once. Currently dependencies on, for example, the error index end up compiling the `x86_64-unknown-linux-gnu` compiler more than necessary. As a result here we move many dependencies on these tools to being produced by a stage0 compiler, not a stage1+ compiler. None of these tools actually need to be staged at all, so they'll exhibit consistent behavior across the stages.
|
☀️ Test successful - status-appveyor, status-travis |
This commit changes all tools and such to get compiled in stage0, not in
later stages. The purpose of this commit is to cut down dependencies on later
stages for future modifications to the build system. Notably we're going to be
adding builders that produce a full suite of cross-compiled artifacts for a
particular host, and that shouldn't compile the
x86_64-unknown-linux-gnucompiler more than once. Currently dependencies on, for example, the error index
end up compiling the
x86_64-unknown-linux-gnucompiler more than necessary.As a result here we move many dependencies on these tools to being produced by a
stage0 compiler, not a stage1+ compiler. None of these tools actually need to be
staged at all, so they'll exhibit consistent behavior across the stages.