-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socket timeout and ttl support in sys::redox
#38707
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
sys::redox
@bors r+ |
📌 Commit 57950fa has been approved by |
Thanks! |
Add socket timeout and ttl support in `sys::redox` This adds support for `read_timeout`, `write_timeout`, and `ttl` on `TcpStream`, `TcpListener`, and `UdpSocket` in the `sys::redox` module. The DNS lookup has been set to use a 5 second timeout by default.
"-Wl,-z,noexecstack".to_string(), | ||
|
||
// Static link | ||
"-static".to_string() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need these extra arguments anymore.
"-static".to_string() | ||
], | ||
late_link_args: vec![ | ||
"-lc".to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need these extra arguments anymore. -lc and -lm will be specified by the cross compiler
], | ||
executables: true, | ||
relocation_model: "static".to_string(), | ||
disable_redzone: true, | ||
eliminate_frame_pointer: false, | ||
target_family: None, | ||
linker_is_gnu: true, | ||
no_default_libraries: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default libraries will be added by the cross compiler
@brson I made one more change - to setup rustc correctly for use with a cross compiler. https://github.com/rust-lang/rust/pull/38707/files#diff-7e2418069cfc6bf086cd8495d2a90af7 |
@bors r+ |
📌 Commit c6858a1 has been approved by |
Thanks @brson! |
Add socket timeout and ttl support in `sys::redox` This adds support for `read_timeout`, `write_timeout`, and `ttl` on `TcpStream`, `TcpListener`, and `UdpSocket` in the `sys::redox` module. The DNS lookup has been set to use a 5 second timeout by default.
☀️ Test successful - status-appveyor, status-travis |
This adds support for
read_timeout
,write_timeout
, andttl
onTcpStream
,TcpListener
, andUdpSocket
in thesys::redox
module.The DNS lookup has been set to use a 5 second timeout by default.