Fix panic when using a macros 1.1 custom derive on a struct containing a macro invocation #38737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeperofdakeys
force-pushed
the
proc-macro-derive-Dec-16
branch
from
52a085c to
22f788c
Compare
jseyfried
approved these changes
Dec 31, 2016
| @@ -29,6 +29,7 @@ use syntax::ext::hygiene::Mark; | |||
| use syntax::ext::tt::macro_rules; | |||
| use syntax::feature_gate::{emit_feature_err, GateIssue}; | |||
| use syntax::fold::Folder; | |||
| use syntax::fold; | |||
There was a problem hiding this comment.
nit: use syntax::fold::{self, Folder}.
| @@ -28,6 +28,9 @@ impl<'a> Visitor<'a> for MarkAttrs<'a> { | |||
| mark_known(attr); | |||
| } | |||
| } | |||
|
|
|||
| fn visit_mac(&mut self, _mac: &Mac) { | |||
| } | |||
There was a problem hiding this comment.
nit: I believe using a single line for empty functions (i.e. fn f(...) {}) is more idiomatic, at least in the compiler.
| } | ||
|
|
||
| fn main() { | ||
| } |
jseyfried
changed the title
|
@bors r+ |
|
📌 Commit e9b5839 has been approved by |
53 tasks
|
Thanks for the quick fix! I asked in #35900 (comment) about backporting this to beta. Is there anything I need to do to make that happen? |
jseyfried
added
beta-nominated
bors
added a commit
that referenced
this pull request
Dec 31, 2016
…yfried Fix panic when using a macros 1.1 custom derive on a struct containing a macro invocation Fixes #38706 r? @jseyfried
|
@dtolnay this is now tagged |
|
☀️ Test successful - status-appveyor, status-travis |
|
Approving for beta. Small patch, regression. cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38706
r? @jseyfried