Rollup of 11 pull requests #38834
Closed
Rollup of 11 pull requests #38834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```rust
let vr = v.iter().filter(|x| {
x % 2 == 0
});
```
will now yield the following compiler output:
```bash
ERROR binary operation `%` cannot be applied to type `&&_`
NOTE this is a reference of a reference to a type that `%` can be applied to,
you need to dereference this variable once for this operation to work
NOTE an implementation of `std::ops::Rem` might be missing for `&&_`
```
The first NOTE is new.
Bug rust-lang#33877
We don't actually use trampoline_setup.c and all the `*tf3` business seems related to f80/f128 business. Specifically this'll fix some warnings showing up during builds on OSX.
Since 8285ab5, which was merged in with rust-lang#38061, the help for the --print option is missing the surrounding [ ] around the possible options. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Due to rust-lang#28728 loop {} is very risky and can lead to fun debugging experiences like in rust-lang#38136. Besides, aborting is probably better behavior than an infinite loop.
book: use abort() over loop {} for panic
Due to rust-lang#28728 `loop {}` is very risky and can lead to fun debugging experiences such as rust-lang#38136. Besides, aborting is probably better behavior than an infinite loop.
r? @steveklabnik
Clarify zero-value behavior of `ctlz`/`cttz` intrinsics. Fixes rust-lang#34381.
…aumeGomez Clarify behavior of `VecDeque::insert`. Fixes rust-lang#37046.
…nkov Test for appropriate span on second custom derive Adds test for and closes rust-lang#36935.
Detect double reference when applying binary op
``` rust
let vr = v.iter().filter(|x| {
x % 2 == 0
});
```
will now yield the following compiler output:
``` bash
ERROR binary operation `%` cannot be applied to type `&&_`
NOTE this is a reference of a reference to a type that `%` can be applied to,
you need to dereference this variable once for this operation to work
NOTE an implementation of `std::ops::Rem` might be missing for `&&_`
```
The first NOTE is new.
Fix rust-lang#33877
----
Thanks to @estebank for providing the original PR rust-lang#34420 (of which this is a tweaked rebase).
…turon std: Remove unused objects from compiler-builtins We don't actually use trampoline_setup.c and all the `*tf3` business seems related to f80/f128 business. Specifically this'll fix some warnings showing up during builds on OSX.
Fix doc for `escape_debug`
Replace uses of `#[unsafe_destructor_blind_to_params]` with `#[may_dangle]` CC rust-lang#34761 r? @pnkfelix
fix help for the --print option Since 8285ab5, which was merged in with rust-lang#38061, the help for the --print option is missing the surrounding [ ] around the possible options. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
|
@bors: r+ p=1 |
|
📌 Commit 6316e43 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 6316e43 with merge 00f0990... |
|
💔 Test failed - status-travis |
|
Hmm, it seems I screwed up my fix to #38617 ; I recognize that old use of I thought I had pushed the corrected version but obviously I did not. |
|
Aha: I did push a corrected commit: b8669df but bors interpreted my r+ here: #38617 (comment) as if it was referring to 98218b3 (again!) |
|
☔ The latest upstream changes (presumably #38138) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctlz/cttzintrinsics. #38310, Clarify behavior ofVecDeque::insert. #38581, Test for appropriate span on second custom derive #38607, Detect double reference when applying binary op #38617, std: Remove unused objects from compiler-builtins #38623, Fix doc forescape_debug#38629, Replace uses of#[unsafe_destructor_blind_to_params]with#[may_dangle]#38664, Doc fix #38799, fix help for the --print option #38815, Add more docs for CoerceUnsized and Unsize #38816