E0088/E0090 fix #38859
Merged
E0088/E0090 fix #38859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb |
|
@bors r+ |
|
📌 Commit 33bb471 has been approved by |
eddyb
added
beta-nominated
|
@bors p=1
|
nikomatsakis
added
the
beta-accepted
|
Accepting for beta backport. Small patch. cc @rust-lang/compiler |
bors
added a commit
that referenced
this pull request
Jan 6, 2017
E0088/E0090 fix This fixes an issue reported by @eddyb (#36208 (comment)) where the check for "too few lifetime parameters" was removed in one of the error message PRs. I also removed the span shrinking from E0088, as early bound lifetimes give you a confusing underline in some cases. r=eddyb
|
💔 Test failed - status-travis |
|
@bors: retry
* osx linker segfaulted
…On Fri, Jan 6, 2017 at 8:54 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189551515>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38859 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95IO1Q3XlbjqavU9YO4hbCISe2kDrks5rPnHPgaJpZM4LcO1i>
.
|
bors
added a commit
that referenced
this pull request
Jan 7, 2017
E0088/E0090 fix This fixes an issue reported by @eddyb (#36208 (comment)) where the check for "too few lifetime parameters" was removed in one of the error message PRs. I also removed the span shrinking from E0088, as early bound lifetimes give you a confusing underline in some cases. r=eddyb
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported by @eddyb (#36208 (comment)) where the check for "too few lifetime parameters" was removed in one of the error message PRs.
I also removed the span shrinking from E0088, as early bound lifetimes give you a confusing underline in some cases.
r=eddyb