Remove note: prefix from type mismatch errors
#38902
Conversation
Given file
```
fn main() {
let x: usize = "";
}
```
provide the following output
```rust
error[E0308]: mismatched types
--> file.rs:2:20
|
2 | let x: usize = "";
| ^^ expected usize, found reference
|
= expected type `usize`
= found type `&'static str`
= help: here are some functions which might fulfill your needs:
- .len()
```
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
| = note: expected type `()` | ||
| = note: found type `std::result::Result<bool, std::io::Error>` | ||
| = expected type `()` | ||
| = found type `std::result::Result<bool, std::io::Error>` | ||
| = help: here are some functions which might fulfill your needs: | ||
| - .unwrap() |
There was a problem hiding this comment.
consider indenting these suggestions? (out of scope for this PR maybe)
There was a problem hiding this comment.
I noticed that, I'll prepare a separate PR for it.
There was a problem hiding this comment.
Created #38916 for this.
| @@ -527,6 +529,7 @@ impl Level { | |||
| Fatal | PhaseFatal | Error => "error", | |||
| Warning => "warning", | |||
| Note => "note", | |||
| TopLevel => "note", | |||
There was a problem hiding this comment.
Ahhh this is unfortunate, external tools parsing rustc JSON output for example wouldn't be able to tell this apart. Which means unavoidable inconsistency between rustc output and external tools.
There was a problem hiding this comment.
It is. I went with this option to avoid breaking existing tooling. If we wan't to make top level comments a general thing, we can give this a differentiated &str identifier. If this will only be used for expected/found messages, then I'd rename the enum variant to something else and the identifier can then be "expected" and "found". I think that'd be beneficial for tools.
estebank
force-pushed
the
top-level-type-errors
branch
from
c621862 to
202aebf
Compare
On errors like the following: ``` error[E0308]: mismatched types --> file.rs:2:20 | 2 | let x: usize = ""; | ^^ expected usize, found reference | = expected type `usize` = found type `&'static str` ``` colorize the expected and found types within '`' with Style::UnderlinePrimary`.
|
Current output colorized:
|
|
relevant comment: #38901 (comment) |
|
☔ The latest upstream changes (presumably #38916) made this pull request unmergeable. Please resolve the merge conflicts. |
Given file
provide the following output
Fix #38901.