Fix UB in test helpers #39095
Merged
Fix UB in test helpers #39095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro expansion producing defined has undefined behavior in C/C++.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Oh, didn't know it was UB. I've thought it was good to define a variable as then the code can be self explaining. Thanks! |
|
@bors: r+ |
|
📌 Commit 5add9b9 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 17, 2017
Fix UB in test helpers Macro expansion producing defined has undefined behavior in C/C++.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro expansion producing defined has undefined behavior in C/C++.