Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Mention rustbuild in Makefile.in comments #39258

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

jacwah
Copy link
Contributor

@jacwah jacwah commented Jan 23, 2017

I think this patch will help newcomers like myself with the build system. I didn't understand that the make targets listed in the Makefile.in comments only worked with the old system, until it was pointed out to me in #39256.

@aturon
Copy link
Member

aturon commented Jan 23, 2017

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 23, 2017

📌 Commit 4d8f1c9 has been approved by aturon

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2017
build: Mention rustbuild in Makefile.in comments

I think this patch will help newcomers like myself with the build system. I didn't understand that the make targets listed in the Makefile.in comments only worked with the old system, until it was pointed out to me in rust-lang#39256.
bors added a commit that referenced this pull request Jan 23, 2017
Rollup of 7 pull requests

- Successful merges: #38794, #38956, #38993, #39191, #39200, #39233, #39258
- Failed merges:
@bors bors merged commit 4d8f1c9 into rust-lang:master Jan 24, 2017
@jacwah jacwah deleted the makefile-note branch October 14, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants