Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full path being output with rustdoc -h #39312

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Fix full path being output with rustdoc -h #39312

merged 1 commit into from
Feb 5, 2017

Conversation

mgattozzi
Copy link
Contributor

rustdoc would output the full path to the binary when calling it with
the -h or --help flags. This is undesired behavior. It has been
replaced with a hardcoded string rustdoc to fix the issue.

Fixes #39310

rustdoc would output the full path to the binary when calling it with
the `-h` or `--help` flags. This is undesired behavior. It has been
replaced with a hardcoded string `rustdoc` to fix the issue.

Fixes #39310
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mgattozzi
Copy link
Contributor Author

@steveklabnik have you had a chance to look at this?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 4, 2017

📌 Commit bb34856 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…richton

Fix full path being output with `rustdoc -h`

rustdoc would output the full path to the binary when calling it with
the `-h` or `--help` flags. This is undesired behavior. It has been
replaced with a hardcoded string `rustdoc` to fix the issue.

Fixes rust-lang#39310
bors added a commit that referenced this pull request Feb 5, 2017
@bors bors merged commit bb34856 into rust-lang:master Feb 5, 2017
@bors
Copy link
Contributor

bors commented Feb 5, 2017

⌛ Testing commit bb34856 with merge 9c8cdb2...

@mgattozzi mgattozzi deleted the rustdoc-help-fix branch February 5, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc --help prints full path to arg0
5 participants