Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short hand struct doc #39459

Merged
merged 5 commits into from
Feb 8, 2017
Merged

Fix short hand struct doc #39459

merged 5 commits into from
Feb 8, 2017

Conversation

phungleson
Copy link
Contributor

Don't want to discredit @HnGiang effort on this issue.

I just want to lend a hand to fix this issue #38830, it is a very nice feature and is seemingly completed.

Fixes #39096

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ghost
Copy link

ghost commented Feb 3, 2017

Thanks @phungleson for help me fix issue #38830

@steveklabnik
Copy link
Member

I think this looks great, thank you! @z1mvader wanted to lend a hand, so let's see what they think. I'm feeling good about this PR, though!

@ghost
Copy link

ghost commented Feb 7, 2017

I'm no authority here but I think it's all right :)

@steveklabnik
Copy link
Member

@bors: r+ rollup

Great! Thanks so much @HnGiang for getting this going, and to @phungleson for keeping it going! ❤️

@bors
Copy link
Contributor

bors commented Feb 7, 2017

📌 Commit 4ddb56b has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 8, 2017
…c, r=steveklabnik

Fix short hand struct doc

Don't want to discredit @HnGiang effort on this issue.

I just want to lend a hand to fix this issue rust-lang#38830, it is a very nice feature and is seemingly completed.

Fixes rust-lang#39096

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 8, 2017
…c, r=steveklabnik

Fix short hand struct doc

Don't want to discredit @HnGiang effort on this issue.

I just want to lend a hand to fix this issue rust-lang#38830, it is a very nice feature and is seemingly completed.

Fixes rust-lang#39096

r? @steveklabnik
bors added a commit that referenced this pull request Feb 8, 2017
Rollup of 13 pull requests

- Successful merges: #38764, #39361, #39372, #39374, #39400, #39426, #39431, #39459, #39482, #39545, #39593, #39620, #39621
- Failed merges:
@bors bors merged commit 4ddb56b into rust-lang:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants