Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version, upgrade bootstrap #39463

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Conversation

alexcrichton
Copy link
Member

This commit updates the version number to 1.17.0 as we're not on that version of
the nightly compiler, and at the same time this updates src/stage0.txt to
bootstrap from freshly minted beta compiler and beta Cargo.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @brson

Also cc @nagisa, @est31 about the i128 staging changes. Would be good to have a second pair of eyes!

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Feb 2, 2017
@nagisa
Copy link
Member

nagisa commented Feb 2, 2017

Changes look good to me.

@est31
Copy link
Member

est31 commented Feb 2, 2017

LGTM to me as well. But we'll only know for sure once bors says its okay :) Little nit: impl LargeInt for u64 and impl LargeInt for i64 could be removed from compiler builtins, if I'm not mistaken.

@alexcrichton
Copy link
Member Author

@est31 removed!

@brson
Copy link
Contributor

brson commented Feb 2, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2017

📌 Commit 64280d2 has been approved by brson

@alexcrichton
Copy link
Member Author

@bors: p=1

(requested by @nagisa)

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 64280d2 with merge 68ae9c1...

bors added a commit that referenced this pull request Feb 3, 2017
Bump version, upgrade bootstrap

This commit updates the version number to 1.17.0 as we're not on that version of
the nightly compiler, and at the same time this updates src/stage0.txt to
bootstrap from freshly minted beta compiler and beta Cargo.
@bors
Copy link
Contributor

bors commented Feb 3, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Feb 3, 2017

📌 Commit 98f1d20 has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 98f1d20 with merge 3386812...

@bors
Copy link
Contributor

bors commented Feb 3, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

@bors: retry

  • cargo test failed to delete a file... here's to praying it's spurious!

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 98f1d20 with merge 7803f96...

@bors
Copy link
Contributor

bors commented Feb 3, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Feb 3, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 98f1d20 with merge 1d20da1...

@bors
Copy link
Contributor

bors commented Feb 3, 2017

💔 Test failed - status-appveyor

@est31
Copy link
Member

est31 commented Feb 3, 2017

Hmm it seems like a spurious bug with Cargo. If code that created this error gets executed with itself in parallel, then it can in theory both times assume that dst exists, leading to the remove being attempted. One instance will then succeed, while the other instance will fail as the file was already removed. According to this playground example, attempting to non existent files leads in the NotFound error kind. Maybe ignore the error if that's the case?

Either way, it looks like the error is spurious, so a retry should be attempted.

This commit updates the version number to 1.17.0 as we're not on that version of
the nightly compiler, and at the same time this updates src/stage0.txt to
bootstrap from freshly minted beta compiler and beta Cargo.
@alexcrichton
Copy link
Member Author

Thanks for the investigation @est31, I'll keep digging and see if I can't come up with a solution.

For now I've backed out the update to Cargo, filed #39504 to track the future update, and otherwise let's land the removal of the i128 staging

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 3, 2017

📌 Commit 626e754 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 626e754 with merge 0648517...

bors added a commit that referenced this pull request Feb 3, 2017
Bump version, upgrade bootstrap

This commit updates the version number to 1.17.0 as we're not on that version of
the nightly compiler, and at the same time this updates src/stage0.txt to
bootstrap from freshly minted beta compiler and beta Cargo.
@bors
Copy link
Contributor

bors commented Feb 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0648517 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants