Let the dep-tracking test framework check that all #[rustc_dirty] attrs have been actually checked #39500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e been actually checked.
|
Before r+ing, please wait for travis to finish as I haven't had the time to run a full |
nikomatsakis
reviewed
Feb 3, 2017
| @@ -914,6 +914,7 @@ pub fn walk_decl<'v, V: Visitor<'v>>(visitor: &mut V, declaration: &'v Decl) { | |||
|
|
|||
| pub fn walk_expr<'v, V: Visitor<'v>>(visitor: &mut V, expression: &'v Expr) { | |||
| visitor.visit_id(expression.id); | |||
| walk_list!(visitor, visit_attribute, expression.attrs.iter()); | |||
nikomatsakis
reviewed
Feb 3, 2017
| }; | ||
| intravisit::walk_crate(&mut all_attrs, krate); | ||
|
|
||
| all_attrs.report_unchecked_attrs(&dirty_clean_visitor.checked_attrs); |
There was a problem hiding this comment.
can we add a comment explaining why we are not using the other "used attribute" system?
is not used for #[rustc_dirty]/#[rustc_clean].
|
@bors r=nikomatsakis (comments added) |
|
📌 Commit ab3c826 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 6, 2017
Let the dep-tracking test framework check that all #[rustc_dirty] attrs have been actually checked r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis