Pass -fPIC to native compiles on 32-bit #39523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is apparently a regression from 1.14.0 to 1.15.0. Previously we passed `-fPIC` to C compilers on i686 targets, but the `gcc` crate apparently [explicitly] didn't do this. I don't recall why that was avoided but it was [previously passed by the makefiles][mk] and this seems to have [caused a regression][regression] in Firefox, so this commit reverts back to passing `-fPIC`. [explicitly]: rust-lang/cc-rs@362bdf20 [mk]: https://github.com/rust-lang/rust/blob/c781fc4a/mk/cfg/i686-unknown-linux-gnu.mk#L11 [regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1336155
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
beta-nominated
|
@bors: r+ |
|
📌 Commit f98f6c7 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 7, 2017
Pass -fPIC to native compiles on 32-bit This is apparently a regression from 1.14.0 to 1.15.0. Previously we passed `-fPIC` to C compilers on i686 targets, but the `gcc` crate apparently [explicitly] didn't do this. I don't recall why that was avoided but it was [previously passed by the makefiles][mk] and this seems to have [caused a regression][regression] in Firefox, so this commit reverts back to passing `-fPIC`. [explicitly]: rust-lang/cc-rs@362bdf20 [mk]: https://github.com/rust-lang/rust/blob/c781fc4a/mk/cfg/i686-unknown-linux-gnu.mk#L11 [regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1336155
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
Pass -fPIC to native compiles on 32-bit This is apparently a regression from 1.14.0 to 1.15.0. Previously we passed `-fPIC` to C compilers on i686 targets, but the `gcc` crate apparently [explicitly] didn't do this. I don't recall why that was avoided but it was [previously passed by the makefiles][mk] and this seems to have [caused a regression][regression] in Firefox, so this commit reverts back to passing `-fPIC`. [explicitly]: rust-lang/cc-rs@362bdf20 [mk]: https://github.com/rust-lang/rust/blob/c781fc4a/mk/cfg/i686-unknown-linux-gnu.mk#L11 [regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1336155
|
@brson @alexcrichton Can we get this in 1.15.1? |
|
@bors p=1 (nominated for beta) |
|
⌛ Testing commit f98f6c7 with merge a20e288... |
|
💔 Test failed - status-travis |
|
|
… On Wed, Feb 8, 2017 at 7:39 AM Ms2ger ***@***.***> wrote:
---- [run-pass] run-pass/issue-24227.rs stdout ----
error: compilation failed!
status: exit code: 101
command: /Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2/bin/rustc /Users/travis/build/rust-lang/rust/src/test/run-pass/issue-24227.rs -L /Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass --target=x86_64-apple-darwin --error-format json -L /Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.stage2-x86_64-apple-darwin.run-pass.libaux -C prefer-dynamic -o /Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.stage2-x86_64-apple-darwin -Crpath -O -Lnative=/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/native/rust-test-helpers
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
{"message":"linking with `cc` failed: exit code: 254","code":null,"level":"error","spans":[],"children":[{"message":"\"cc\" \"-m64\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.0.o\" \"-o\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.stage2-x86_64-apple-darwin\" \"-Wl,-dead_strip\" \"-nodefaultlibs\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.stage2-x86_64-apple-darwin.run-pass.libaux\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/native/rust-test-helpers\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib\" \"-L\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib\" \"-l\" \"std-babe254b64e6389b\" \"/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-a156453e4a4418dc.rlib\" \"-l\" \"System\" \"-l\" \"pthread\" \"-l\" \"c\" \"-l\" \"m\" ***@***.***_path/../../stage2/lib/rustlib/x86_64-apple-darwin/lib\" \"-Wl,-rpath,/usr/local/lib/rustlib/x86_64-apple-darwin/lib\"","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"ld: warning: directory not found for option '-L/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/test/run-pass/issue-24227.stage2-x86_64-apple-darwin.run-pass.libaux'\nclang: error: unable to execute command: Segmentation fault: 11\nclang: error: linker command failed due to signal (use -v to see invocation)\n","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":null}
{"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":null}
------------------------------------------
thread '[run-pass] run-pass/issue-24227.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2575
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39523 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EqSMsKcsoTfhakguUcwRQ8TX2hBks5raeG0gaJpZM4L3Dub>
.
|
|
⌛ Testing commit f98f6c7 with merge 14bc58f... |
|
💔 Test failed - status-travis |
|
… On Wed, Feb 8, 2017 at 10:11 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/199665906>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39523 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95G1INOCucFT2p0hs-kdZ-dqd8M8zks5ragU6gaJpZM4L3Dub>
.
|
bors
added a commit
that referenced
this pull request
Feb 8, 2017
Pass -fPIC to native compiles on 32-bit This is apparently a regression from 1.14.0 to 1.15.0. Previously we passed `-fPIC` to C compilers on i686 targets, but the `gcc` crate apparently [explicitly] didn't do this. I don't recall why that was avoided but it was [previously passed by the makefiles][mk] and this seems to have [caused a regression][regression] in Firefox, so this commit reverts back to passing `-fPIC`. [explicitly]: rust-lang/cc-rs@362bdf20 [mk]: https://github.com/rust-lang/rust/blob/c781fc4a/mk/cfg/i686-unknown-linux-gnu.mk#L11 [regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1336155
|
☀️ Test successful - status-appveyor, status-travis |
Merged
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 9, 2017
This is a smaller and more targeted backport of rust-lang#39523 which drives to the heart of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this commit can be found in rust-lang#39523 itself.
alexcrichton
added
the
beta-accepted
|
Backported in #39667 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 9, 2017
This is a smaller and more targeted backport of rust-lang#39523 which drives to the heart of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this commit can be found in rust-lang#39523 itself.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 10, 2017
Use a custom build of rust 1.15.1 with an additional bump of the gcc crate to 0.3.43 to pass -fPIC to the C compiler on i686-linux. While 1.15.1 was tagged today, there's some question as to whether it would be released from the tag or if the tag would be moved to incorporate this fix. This works around the issue with text segment relocations with the 1.15.0 stable release. For more information see the upstream issue at rust-lang/rust#39523 MozReview-Commit-ID: 83IxtJeJxlh --HG-- extra : rebase_source : 8deda9058c77a98c65a46949768702c56296d9d4
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Feb 10, 2017
Use a custom build of rust 1.15.1 with an additional bump of the gcc crate to 0.3.43 to pass -fPIC to the C compiler on i686-linux. While 1.15.1 was tagged today, there's some question as to whether it would be released from the tag or if the tag would be moved to incorporate this fix. This works around the issue with text segment relocations with the 1.15.0 stable release. For more information see the upstream issue at rust-lang/rust#39523 MozReview-Commit-ID: 83IxtJeJxlh
alexcrichton
removed
the
beta-nominated
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
Use a custom build of rust 1.15.1 with an additional bump of the gcc crate to 0.3.43 to pass -fPIC to the C compiler on i686-linux. While 1.15.1 was tagged today, there's some question as to whether it would be released from the tag or if the tag would be moved to incorporate this fix. This works around the issue with text segment relocations with the 1.15.0 stable release. For more information see the upstream issue at rust-lang/rust#39523 MozReview-Commit-ID: 83IxtJeJxlh UltraBlame original commit: 62adf4084bae5e2f6d49cd3c4c6cbfbc2691a2aa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
Use a custom build of rust 1.15.1 with an additional bump of the gcc crate to 0.3.43 to pass -fPIC to the C compiler on i686-linux. While 1.15.1 was tagged today, there's some question as to whether it would be released from the tag or if the tag would be moved to incorporate this fix. This works around the issue with text segment relocations with the 1.15.0 stable release. For more information see the upstream issue at rust-lang/rust#39523 MozReview-Commit-ID: 83IxtJeJxlh UltraBlame original commit: 62adf4084bae5e2f6d49cd3c4c6cbfbc2691a2aa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
Use a custom build of rust 1.15.1 with an additional bump of the gcc crate to 0.3.43 to pass -fPIC to the C compiler on i686-linux. While 1.15.1 was tagged today, there's some question as to whether it would be released from the tag or if the tag would be moved to incorporate this fix. This works around the issue with text segment relocations with the 1.15.0 stable release. For more information see the upstream issue at rust-lang/rust#39523 MozReview-Commit-ID: 83IxtJeJxlh UltraBlame original commit: 62adf4084bae5e2f6d49cd3c4c6cbfbc2691a2aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is apparently a regression from 1.14.0 to 1.15.0. Previously we
passed
-fPICto C compilers on i686 targets, but thegcccrateapparently explicitly didn't do this. I don't recall why that was
avoided but it was previously passed by the makefiles and this
seems to have caused a regression in Firefox, so this
commit reverts back to passing
-fPIC.