Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve format float #39615

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Improve format float #39615

merged 1 commit into from
Feb 9, 2017

Conversation

phungleson
Copy link
Contributor

@phungleson phungleson commented Feb 7, 2017 •
edited
Loading

  • Move float into mod float like in test
  • Add more tests for f64 f32, lower exp, upper exp, which can come if handy in the future if we want refactor further
  • Use assert_eq for clearer error messages

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@phungleson
Improve fmt float
2ba0b65 
* Move to a separate float mod
* Add more tests for f64 f32 lower exp upper exp
* Use assert_eq for a clearer error message
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 7, 2017

📌 Commit 2ba0b65 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 8, 2017
@frewsxcv
Rollup merge of rust-lang#39615 - phungleson:corefloat, r=alexcrichton
530aee8 
Improve format float

* Move float into mod float like in test
* Add more tests for f64 f32, lower exp, upper exp, which can come if handy in the future if we want refactor further
* Use `assert_eq` for clearer error messages
@frewsxcv frewsxcv mentioned this pull request Feb 8, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 9, 2017
@frewsxcv
Rollup merge of rust-lang#39615 - phungleson:corefloat, r=alexcrichton
8f65d75 
Improve format float

* Move float into mod float like in test
* Add more tests for f64 f32, lower exp, upper exp, which can come if handy in the future if we want refactor further
* Use `assert_eq` for clearer error messages
@frewsxcv frewsxcv mentioned this pull request Feb 9, 2017
Merged
bors added a commit that referenced this pull request Feb 9, 2017
@bors
Auto merge of #39686 - frewsxcv:rollup, r=frewsxcv
e7fc53b 
Rollup of 5 pull requests

- Successful merges: #39595, #39601, #39602, #39615, #39647
- Failed merges:
@bors bors merged commit 2ba0b65 into rust-lang:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phungleson @rust-highfive @alexcrichton @bors @aturon