Don't include directory names in shasums #39660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we just run `shasum` on an absolute path but right now the shasum files only include filenames, so let's use `current_dir` and just the file name to only have the file name emitted.
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 67574cc has been approved by |
Member
Author
|
Nominating for a beta backport |
alexcrichton
added
the
beta-nominated
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 11, 2017
Don't include directory names in shasums Right now we just run `shasum` on an absolute path but right now the shasum files only include filenames, so let's use `current_dir` and just the file name to only have the file name emitted.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 11, 2017
Don't include directory names in shasums Right now we just run `shasum` on an absolute path but right now the shasum files only include filenames, so let's use `current_dir` and just the file name to only have the file name emitted.
bors
added a commit
that referenced
this pull request
Feb 11, 2017
Collaborator
alexcrichton
added
the
beta-accepted
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we just run
shasumon an absolute path but right now the shasumfiles only include filenames, so let's use
current_dirand just the file nameto only have the file name emitted.