change span_notes to notes in E0368/E0369 #39707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. @bors r+ |
|
📌 Commit 79bf98d has been approved by |
durka
force-pushed
the
parsimonious-span-note
branch
from
79bf98d to
9fffd14
Compare
|
Tidy failure fixed. |
|
@bors r+ |
|
📌 Commit 9fffd14 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 10, 2017
…athandturner change span_notes to notes in E0368/E0369 Fixes rust-lang#39650. All the uses of `span_note` in these errors were reusing the same span as the original error, which causes unnecessary repetition. For an example, see the changes to [src/test/ui/span/issue-39018.stderr](https://github.com/rust-lang/rust/pull/39707/files?diff=unified#diff-46336f62958fdb34233db414cb9914a1R4). r? @jonathandturner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39650.
All the uses of
span_notein these errors were reusing the same span as the original error, which causes unnecessary repetition.For an example, see the changes to src/test/ui/span/issue-39018.stderr.
r? @jonathandturner