Clean up "pattern doesn't bind x" messages #39713

estebank · 2017-02-10T01:59:26Z

Group "missing variable bind" spans in or matches and clarify wording
for the two possible cases: when a variable from the first pattern is
not in any of the subsequent patterns, and when a variable in any of the
other patterns is not in the first one.

Before:

error[E0408]: variable `a` from pattern #1 is not bound in pattern #2
  --> file.rs:10:23
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                       ^^^^^^^^^^^ pattern doesn't bind `a`

error[E0408]: variable `b` from pattern #2 is not bound in pattern #1
  --> file.rs:10:32
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                                ^ pattern doesn't bind `b`

error[E0408]: variable `a` from pattern #1 is not bound in pattern #3
  --> file.rs:10:37
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                                     ^^^^^^^^ pattern doesn't bind `a`

error[E0408]: variable `d` from pattern #1 is not bound in pattern #3
  --> file.rs:10:37
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                                     ^^^^^^^^ pattern doesn't bind `d`

error[E0408]: variable `c` from pattern #3 is not bound in pattern #1
  --> file.rs:10:43
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                                           ^ pattern doesn't bind `c`

error[E0408]: variable `d` from pattern #1 is not bound in pattern #4
  --> file.rs:10:48
   |
10 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                                                ^^^^^^^^ pattern doesn't bind `d`

error: aborting due to 6 previous errors

After:

error[E0408]: variable `d` is not bound in all patterns
  --> $DIR/issue-39698.rs:20:37
   |
20 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |                  -          -       ^^^^^^^^   ^^^^^^^^ pattern doesn't bind `d`
   |                  |          |       |
   |                  |          |       pattern doesn't bind `d`
   |                  |          variable not in all patterns
   |                  variable not in all patterns

error[E0408]: variable `c` is not bound in all patterns
  --> $DIR/issue-39698.rs:20:48
   |
20 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |         ^^^^^^^^^^^   ^^^^^^^^^^^         -    ^^^^^^^^ pattern doesn't bind `c`
   |         |             |                   |
   |         |             |                   variable not in all patterns
   |         |             pattern doesn't bind `c`
   |         pattern doesn't bind `c`

error[E0408]: variable `a` is not bound in all patterns
  --> $DIR/issue-39698.rs:20:37
   |
20 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |               -       ^^^^^^^^^^^   ^^^^^^^^         - variable not in all patterns
   |               |       |             |
   |               |       |             pattern doesn't bind `a`
   |               |       pattern doesn't bind `a`
   |               variable not in all patterns

error[E0408]: variable `b` is not bound in all patterns
  --> $DIR/issue-39698.rs:20:37
   |
20 |         T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); }
   |         ^^^^^^^^^^^            -    ^^^^^^^^   ^^^^^^^^ pattern doesn't bind `b`
   |         |                      |    |
   |         |                      |    pattern doesn't bind `b`
   |         |                      variable not in all patterns
   |         pattern doesn't bind `b`

error: aborting due to 4 previous errors

Fixes #39698.

rust-highfive · 2017-02-10T01:59:31Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2017-02-10T02:00:11Z

Colored output:

osa1 · 2017-02-10T06:27:00Z

This is still inconsistent I think. I don't understand why the first error message is any different than the second one. If first one reports that a is missing from the second and third patterns, second shoyuld return that b is missing from first, third, and fourth pattern in the exact same way. I don't see why would you say the same thing in a different way second time.

eddyb · 2017-02-10T07:04:18Z

r? @jonathandturner

sophiajt · 2017-02-14T20:42:00Z

@estebank - any thoughts on the proposal at #39698 (comment) ?

estebank · 2017-02-14T21:29:31Z

@jonathandturner the current output looks this way, which I believe is what you were proposing in that comment:

solson · 2017-02-14T21:44:29Z

It's a minor thing, but do you think it's worth sorting the pattern numbers?

Instead of: isn't bound in patterns #2, #4, #1

We could have: isn't bound in patterns #1, #2, #4

solson · 2017-02-14T21:46:34Z

In the example in the screenshot, can we avoid printing a message for variable a twice? The first two errors seem redundant. (I would expect to only see the second one, that points at a in pattern #1.)

Likewise for d, I would only expect to see the error pointing at d in pattern #1 (the earliest pattern in which it appears, which the message refers to).

estebank · 2017-02-14T22:50:33Z

@solson:

solson · 2017-02-14T22:52:56Z

@estebank Looking good! There are some errors in the output now, though. The first error's text talks about variable c but its spans are pointing to d and patterns missing d, for example.

sophiajt · 2017-02-14T22:57:04Z

@estebank - is that latest screenshot the real thing? If so, the second error looks wrong. Shouldn't it be 'c'?

solson · 2017-02-14T23:00:41Z

They're actually all wrong. :) There's a mismatch between the text and spans, but at least the spans in isolation look good now (i.e. blue points to variables and corresponding red points to patterns missing those variables).

estebank · 2017-02-14T23:03:32Z

@solson @jonathandturner copy paste error.

solson · 2017-02-15T00:00:43Z

@estebank Looks great!

My only remaining question is whether we should have variable not in all patterns for every instance of the binding or just the first, but I don't mind how it is now.

sophiajt · 2017-02-15T00:08:35Z

Yeah, looks good. Once we get the travis stuff sorted will review. Is that specific to this PR or a general travis issue?

estebank · 2017-02-15T00:14:58Z

My only remaining question is whether we should have variable not in all patterns for every instance of the binding or just the first, but I don't mind how it is now.

I'd lean towards keeping the label.

Yeah, looks good. Once we get the travis stuff sorted will review. Is that specific to this PR or a general travis issue?

It's a regression:

  0 - |error[E0409]: variable `y` is bound with different mode in pattern #2 than in pattern #1|
    + |error[E0409]: variable `y` is bound with different mode in pattern #1 than in pattern #1|

I just fixed it, and now the diagnostic actually checks for mismatched bindings in patterns other than the first one:

instead of

sophiajt · 2017-02-15T04:37:05Z

Great! Is this ready for review now?

estebank · 2017-02-15T04:50:10Z

Yes, it is 😃

sophiajt · 2017-02-21T03:34:34Z

@estebank - seems like the failure is potentially legit, as if the error still isn't quite deterministic

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2047/job/bys2pl5ekyaomw69

estebank · 2017-03-04T16:01:47Z

@jonathandturner sorry for the slow turn around, was offline for the past two weeks.

The code is now sorting all spans, to avoid differences caused by different orderings when traversing HashMaps across platforms. I believe this should be enough. While I was at it, I also rebased and squashed against last master.

eddyb · 2017-03-04T16:14:48Z

@estebank You can always use BTreeMap instead of HashMap.

sophiajt · 2017-03-05T20:31:23Z

@estebank - can you sync with @eddyb to see if there's a solution that works with him? (eg his proposal of using BTreeMap)

estebank · 2017-03-05T23:30:45Z

@jonathandturner sure!

@eddyb I changed the code to use BTreeSet instead of FxHashSet. Does that seem reasonable?

Current colored output for reference:

sophiajt · 2017-03-06T00:05:58Z

Great! Thanks @estebank

@bors r+

bors · 2017-03-06T00:05:59Z

📌 Commit 780bea5 has been approved by jonathandturner

…rner Clean up "pattern doesn't bind x" messages Group "missing variable bind" spans in `or` matches and clarify wording for the two possible cases: when a variable from the first pattern is not in any of the subsequent patterns, and when a variable in any of the other patterns is not in the first one. Before: ```rust error[E0408]: variable `a` from pattern #1 is not bound in pattern rust-lang#2 --> file.rs:10:23 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `b` from pattern rust-lang#2 is not bound in pattern #1 --> file.rs:10:32 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `b` error[E0408]: variable `a` from pattern #1 is not bound in pattern rust-lang#3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `d` from pattern #1 is not bound in pattern rust-lang#3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error[E0408]: variable `c` from pattern rust-lang#3 is not bound in pattern #1 --> file.rs:10:43 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `c` error[E0408]: variable `d` from pattern #1 is not bound in pattern rust-lang#4 --> file.rs:10:48 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error: aborting due to 6 previous errors ``` After: ```rust error[E0408]: variable `d` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | - - ^^^^^^^^ ^^^^^^^^ pattern doesn't bind `d` | | | | | | | pattern doesn't bind `d` | | variable not in all patterns | variable not in all patterns error[E0408]: variable `c` is not bound in all patterns --> $DIR/issue-39698.rs:20:48 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ ^^^^^^^^^^^ - ^^^^^^^^ pattern doesn't bind `c` | | | | | | | variable not in all patterns | | pattern doesn't bind `c` | pattern doesn't bind `c` error[E0408]: variable `a` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | - ^^^^^^^^^^^ ^^^^^^^^ - variable not in all patterns | | | | | | | pattern doesn't bind `a` | | pattern doesn't bind `a` | variable not in all patterns error[E0408]: variable `b` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ - ^^^^^^^^ ^^^^^^^^ pattern doesn't bind `b` | | | | | | | pattern doesn't bind `b` | | variable not in all patterns | pattern doesn't bind `b` error: aborting due to 4 previous errors ``` Fixes rust-lang#39698.

bors · 2017-03-06T02:18:11Z

🔒 Merge conflict

Group "missing variable bind" spans in `or` matches and clarify wording for the two possible cases: when a variable from the first pattern is not in any of the subsequent patterns, and when a variable in any of the other patterns is not in the first one. Before: ``` error[E0408]: variable `a` from pattern rust-lang#1 is not bound in pattern rust-lang#2 --> file.rs:10:23 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `b` from pattern rust-lang#2 is not bound in pattern rust-lang#1 --> file.rs:10:32 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `b` error[E0408]: variable `a` from pattern rust-lang#1 is not bound in pattern rust-lang#3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `d` from pattern rust-lang#1 is not bound in pattern rust-lang#3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error[E0408]: variable `c` from pattern rust-lang#3 is not bound in pattern rust-lang#1 --> file.rs:10:43 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `c` error[E0408]: variable `d` from pattern rust-lang#1 is not bound in pattern rust-lang#4 --> file.rs:10:48 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error: aborting due to 6 previous errors ``` After: ``` error[E0408]: variable `a` is not bound in all patterns --> file.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { intln!("{:?}", a); } | - ^^^^^^^^^^^ ^^^^^^^^ - variable t in all patterns | | | | | | | pattern doesn't bind `a` | | pattern doesn't bind `a` | variable not in all patterns error[E0408]: variable `d` is not bound in all patterns --> file.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { intln!("{:?}", a); } | - - ^^^^^^^^ ^^^^^^^^ pattern esn't bind `d` | | | | | | | pattern doesn't bind `d` | | variable not in all patterns | variable not in all patterns error[E0408]: variable `b` is not bound in all patterns --> file.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { intln!("{:?}", a); } | ^^^^^^^^^^^ - ^^^^^^^^ ^^^^^^^^ pattern esn't bind `b` | | | | | | | pattern doesn't bind `b` | | variable not in all patterns | pattern doesn't bind `b` error[E0408]: variable `c` is not bound in all patterns --> file.rs:20:48 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { intln!("{:?}", a); } | ^^^^^^^^^^^ ^^^^^^^^^^^ - ^^^^^^^^ pattern esn't bind `c` | | | | | | | variable not in all tterns | | pattern doesn't bind `c` | pattern doesn't bind `c` error: aborting due to 4 previous errors ``` * Have only one presentation for binding consistency errors * Point to same binding in multiple patterns when possible * Check inconsistent bindings in all arms * Simplify wording of diagnostic message * Sort emition and spans of binding errors for deterministic output

estebank · 2017-03-06T03:22:46Z

Rebased against master HEAD because of the bors merge conflict message, but wasn't necessary.

alexcrichton · 2017-03-06T16:49:25Z

@bors: r=jonathandturner

bors · 2017-03-06T16:49:26Z

📌 Commit 3ffa4b5 has been approved by jonathandturner

bors · 2017-03-07T16:38:31Z

⌛ Testing commit 3ffa4b5 with merge 2e6413c...

bors · 2017-03-07T18:08:09Z

💔 Test failed - status-travis

alexcrichton · 2017-03-07T19:08:50Z

@bors: retry * osx linker segfault #38878

…

On Tue, Mar 7, 2017 at 12:08 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/208653831> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39713 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95AeIdXd99eLx7aikJGD-6E7M7ar6ks5rjZ0KgaJpZM4L86IO> .

bors · 2017-03-08T09:30:18Z

⌛ Testing commit 3ffa4b5 with merge f91c3f6...

Clean up "pattern doesn't bind x" messages Group "missing variable bind" spans in `or` matches and clarify wording for the two possible cases: when a variable from the first pattern is not in any of the subsequent patterns, and when a variable in any of the other patterns is not in the first one. Before: ```rust error[E0408]: variable `a` from pattern #1 is not bound in pattern #2 --> file.rs:10:23 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `b` from pattern #2 is not bound in pattern #1 --> file.rs:10:32 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `b` error[E0408]: variable `a` from pattern #1 is not bound in pattern #3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `a` error[E0408]: variable `d` from pattern #1 is not bound in pattern #3 --> file.rs:10:37 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error[E0408]: variable `c` from pattern #3 is not bound in pattern #1 --> file.rs:10:43 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^ pattern doesn't bind `c` error[E0408]: variable `d` from pattern #1 is not bound in pattern #4 --> file.rs:10:48 | 10 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^ pattern doesn't bind `d` error: aborting due to 6 previous errors ``` After: ```rust error[E0408]: variable `d` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | - - ^^^^^^^^ ^^^^^^^^ pattern doesn't bind `d` | | | | | | | pattern doesn't bind `d` | | variable not in all patterns | variable not in all patterns error[E0408]: variable `c` is not bound in all patterns --> $DIR/issue-39698.rs:20:48 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ ^^^^^^^^^^^ - ^^^^^^^^ pattern doesn't bind `c` | | | | | | | variable not in all patterns | | pattern doesn't bind `c` | pattern doesn't bind `c` error[E0408]: variable `a` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | - ^^^^^^^^^^^ ^^^^^^^^ - variable not in all patterns | | | | | | | pattern doesn't bind `a` | | pattern doesn't bind `a` | variable not in all patterns error[E0408]: variable `b` is not bound in all patterns --> $DIR/issue-39698.rs:20:37 | 20 | T::T1(a, d) | T::T2(d, b) | T::T3(c) | T::T4(a) => { println!("{:?}", a); } | ^^^^^^^^^^^ - ^^^^^^^^ ^^^^^^^^ pattern doesn't bind `b` | | | | | | | pattern doesn't bind `b` | | variable not in all patterns | pattern doesn't bind `b` error: aborting due to 4 previous errors ``` Fixes #39698.

bors · 2017-03-08T12:17:07Z

☀️ Test successful - status-appveyor, status-travis
Approved by: jonathandturner
Pushing f91c3f6 to master...

rust-highfive assigned eddyb Feb 10, 2017

estebank mentioned this pull request Feb 10, 2017

Inconsistent "pattern doesn't bind x" messages in or patterns #39698

Closed

estebank force-pushed the issue-39698 branch 4 times, most recently from 3d144f0 to 738b0f3 Compare February 10, 2017 05:33

rust-highfive assigned sophiajt and unassigned eddyb Feb 10, 2017

estebank force-pushed the issue-39698 branch 3 times, most recently from 963ee74 to 90aa9b2 Compare February 14, 2017 18:06

estebank force-pushed the issue-39698 branch from 90aa9b2 to fa3e19f Compare February 14, 2017 21:28

estebank force-pushed the issue-39698 branch 2 times, most recently from fc22cb8 to b0d0272 Compare March 4, 2017 05:49

eddyb approved these changes Mar 6, 2017

View reviewed changes

frewsxcv mentioned this pull request Mar 6, 2017

Rollup of 5 pull requests #40286

Closed

estebank added 2 commits March 6, 2017 00:20

Use BTreeSet instead of FxHashSet

3ffa4b5

estebank force-pushed the issue-39698 branch from 780bea5 to 3ffa4b5 Compare March 6, 2017 03:20

bors merged commit 3ffa4b5 into rust-lang:master Mar 8, 2017

estebank mentioned this pull request Mar 23, 2017

E0408 needs to be updated to new format #35698

Closed

estebank deleted the issue-39698 branch November 9, 2023 05:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up "pattern doesn't bind x" messages #39713

Clean up "pattern doesn't bind x" messages #39713

estebank commented Feb 10, 2017 •

edited

Loading

rust-highfive commented Feb 10, 2017

estebank commented Feb 10, 2017

osa1 commented Feb 10, 2017

eddyb commented Feb 10, 2017

sophiajt commented Feb 14, 2017

estebank commented Feb 14, 2017

solson commented Feb 14, 2017 •

edited

Loading

solson commented Feb 14, 2017 •

edited

Loading

estebank commented Feb 14, 2017

solson commented Feb 14, 2017

sophiajt commented Feb 14, 2017

solson commented Feb 14, 2017 •

edited

Loading

estebank commented Feb 14, 2017 •

edited

Loading

solson commented Feb 15, 2017 •

edited

Loading

sophiajt commented Feb 15, 2017

estebank commented Feb 15, 2017 •

edited

Loading

sophiajt commented Feb 15, 2017

estebank commented Feb 15, 2017

sophiajt commented Feb 21, 2017

estebank commented Mar 4, 2017

eddyb commented Mar 4, 2017

sophiajt commented Mar 5, 2017

estebank commented Mar 5, 2017 •

edited

Loading

sophiajt commented Mar 6, 2017

bors commented Mar 6, 2017

bors commented Mar 6, 2017

estebank commented Mar 6, 2017

alexcrichton commented Mar 6, 2017

bors commented Mar 6, 2017

bors commented Mar 7, 2017

bors commented Mar 7, 2017

alexcrichton commented Mar 7, 2017 via email

bors commented Mar 8, 2017

bors commented Mar 8, 2017

Clean up "pattern doesn't bind x" messages #39713

Clean up "pattern doesn't bind x" messages #39713

Conversation

estebank commented Feb 10, 2017 • edited Loading

rust-highfive commented Feb 10, 2017

estebank commented Feb 10, 2017

osa1 commented Feb 10, 2017

eddyb commented Feb 10, 2017

sophiajt commented Feb 14, 2017

estebank commented Feb 14, 2017

solson commented Feb 14, 2017 • edited Loading

solson commented Feb 14, 2017 • edited Loading

estebank commented Feb 14, 2017

solson commented Feb 14, 2017

sophiajt commented Feb 14, 2017

solson commented Feb 14, 2017 • edited Loading

estebank commented Feb 14, 2017 • edited Loading

solson commented Feb 15, 2017 • edited Loading

sophiajt commented Feb 15, 2017

estebank commented Feb 15, 2017 • edited Loading

sophiajt commented Feb 15, 2017

estebank commented Feb 15, 2017

sophiajt commented Feb 21, 2017

estebank commented Mar 4, 2017

eddyb commented Mar 4, 2017

sophiajt commented Mar 5, 2017

estebank commented Mar 5, 2017 • edited Loading

sophiajt commented Mar 6, 2017

bors commented Mar 6, 2017

bors commented Mar 6, 2017

estebank commented Mar 6, 2017

alexcrichton commented Mar 6, 2017

bors commented Mar 6, 2017

bors commented Mar 7, 2017

bors commented Mar 7, 2017

alexcrichton commented Mar 7, 2017 via email

bors commented Mar 8, 2017

bors commented Mar 8, 2017

estebank commented Feb 10, 2017 •

edited

Loading

solson commented Feb 14, 2017 •

edited

Loading

solson commented Feb 14, 2017 •

edited

Loading

solson commented Feb 14, 2017 •

edited

Loading

estebank commented Feb 14, 2017 •

edited

Loading

solson commented Feb 15, 2017 •

edited

Loading

estebank commented Feb 15, 2017 •

edited

Loading

estebank commented Mar 5, 2017 •

edited

Loading