Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that -fPIC is applied #39803

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Add a test that -fPIC is applied #39803

merged 2 commits into from
Mar 2, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented Feb 14, 2017

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.

@alexcrichton
Copy link
Member

@bors: r+

Let's find out!

@bors
Copy link
Contributor

bors commented Feb 14, 2017

📌 Commit 9cad324 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 14, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@frewsxcv
Copy link
Member

@brson
Copy link
Contributor Author

brson commented Feb 15, 2017

comparing UNAME to Windows is bogus

@brson
Copy link
Contributor Author

brson commented Feb 15, 2017

@bors r=alexcrichton

Picked a different env var.

@bors
Copy link
Contributor

bors commented Feb 15, 2017

📌 Commit e77f856 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors
Copy link
Contributor

bors commented Feb 16, 2017

⌛ Testing commit e77f856 with merge be9f0bf...

@bors
Copy link
Contributor

bors commented Feb 16, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Feb 16, 2017 via email

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors
Copy link
Contributor

bors commented Feb 17, 2017

⌛ Testing commit e77f856 with merge f5f6207...

@bors
Copy link
Contributor

bors commented Feb 17, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 1, 2017

📌 Commit 55dab70 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 1, 2017

⌛ Testing commit 55dab70 with merge f5635fa...

bors added a commit that referenced this pull request Mar 1, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors
Copy link
Contributor

bors commented Mar 1, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 1, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 1, 2017

⌛ Testing commit 55dab70 with merge d095437...

bors added a commit that referenced this pull request Mar 1, 2017
Add a test that -fPIC is applied

r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
@bors
Copy link
Contributor

bors commented Mar 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d095437 to master...

@bors bors merged commit 55dab70 into rust-lang:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants