test: Verify all sysroot crates are unstable #39851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
My current plan for bringing external crates to the compiler is that we'll pass |
brson
added
the
relnotes
|
relnotes because the backcompat thing, though probably nobody ever noticed. @bors r+ |
|
📌 Commit 1a0f9d2 has been approved by |
|
cc @japaric dropping the shims may affect xargo |
|
Hm so actually I'm not sure that the strategy of |
alexcrichton
force-pushed
the
verify-unstable
branch
from
1a0f9d2
to
f313646
Compare
|
@bors: r=brson |
|
📌 Commit f313646 has been approved by |
|
Thanks for the ping, @brson. Today's Xargo doesn't depend on the shim crates and it's up to the end user to adapt to changes in the std facade (there's a Xargo.toml where you declare what crates from the std facade you want to build) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
test: Verify all sysroot crates are unstable As we continue to add more crates to the compiler and use them to implement various features we want to be sure we're not accidentally expanding the API surface area of the compiler! To that end this commit adds a new `run-make` test which will attempt to `extern crate foo` all crates in the sysroot, verifying that they're all unstable. This commit discovered that the `std_shim` and `test_shim` crates were accidentally stable and fixes the situation by deleting those shims. The shims are no longer necessary due to changes in Cargo that have happened since they were originally incepted.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
test: Verify all sysroot crates are unstable As we continue to add more crates to the compiler and use them to implement various features we want to be sure we're not accidentally expanding the API surface area of the compiler! To that end this commit adds a new `run-make` test which will attempt to `extern crate foo` all crates in the sysroot, verifying that they're all unstable. This commit discovered that the `std_shim` and `test_shim` crates were accidentally stable and fixes the situation by deleting those shims. The shims are no longer necessary due to changes in Cargo that have happened since they were originally incepted.
|
⌛ Testing commit f313646 with merge 8f7c975... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Fri, Feb 17, 2017 at 1:02 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202723016>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39851 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95IZ4J5u0mE0qbA7DH77Xw23vD6sIks5rde6xgaJpZM4MB-fz>
.
|
|
⌛ Testing commit f313646 with merge 4e1e670... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Fri, Feb 17, 2017 at 2:26 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/202739359>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39851 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95NB9lcEdgIB8VCnIynAYNIebQt3uks5rdgJhgaJpZM4MB-fz>
.
|
|
⌛ Testing commit f313646 with merge 2e77c41... |
|
💔 Test failed - status-appveyor |
|
@bors: r=brson |
|
📌 Commit 472f02d has been approved by |
|
⌛ Testing commit 472f02d with merge e3ea8a8... |
|
💔 Test failed - status-appveyor |
alexcrichton
force-pushed
the
verify-unstable
branch
from
472f02d
to
f9dabcf
Compare
|
@bors: r=brson |
|
📌 Commit f9dabcf has been approved by |
|
⌛ Testing commit f9dabcf with merge a836657... |
|
💔 Test failed - status-appveyor |
As we continue to add more crates to the compiler and use them to implement various features we want to be sure we're not accidentally expanding the API surface area of the compiler! To that end this commit adds a new `run-make` test which will attempt to `extern crate foo` all crates in the sysroot, verifying that they're all unstable. This commit discovered that the `std_shim` and `test_shim` crates were accidentally stable and fixes the situation by deleting those shims. The shims are no longer necessary due to changes in Cargo that have happened since they were originally incepted.
alexcrichton
force-pushed
the
verify-unstable
branch
from
f9dabcf
to
40aaa65
Compare
|
@bors: r=brson |
|
📌 Commit 40aaa65 has been approved by |
|
⌛ Testing commit 40aaa65 with merge 968f054... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network failure
…On Tue, Feb 21, 2017 at 3:08 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/203961117>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39851 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95NdWl8LkXX2NNWInk-dFy0ssD3guks5re1I5gaJpZM4MB-fz>
.
|
bors
added a commit
that referenced
this pull request
Feb 23, 2017
test: Verify all sysroot crates are unstable As we continue to add more crates to the compiler and use them to implement various features we want to be sure we're not accidentally expanding the API surface area of the compiler! To that end this commit adds a new `run-make` test which will attempt to `extern crate foo` all crates in the sysroot, verifying that they're all unstable. This commit discovered that the `std_shim` and `test_shim` crates were accidentally stable and fixes the situation by deleting those shims. The shims are no longer necessary due to changes in Cargo that have happened since they were originally incepted.
|
💔 Test failed - status-travis |
|
@bors: retry
* spurious osx timeout?
…On Thu, Feb 23, 2017 at 6:15 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/204515618>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39851 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95LBTv_W82tLbl-LvRFDABBrQq9v4ks5rfXh3gaJpZM4MB-fz>
.
|
bors
added a commit
that referenced
this pull request
Feb 24, 2017
test: Verify all sysroot crates are unstable As we continue to add more crates to the compiler and use them to implement various features we want to be sure we're not accidentally expanding the API surface area of the compiler! To that end this commit adds a new `run-make` test which will attempt to `extern crate foo` all crates in the sysroot, verifying that they're all unstable. This commit discovered that the `std_shim` and `test_shim` crates were accidentally stable and fixes the situation by deleting those shims. The shims are no longer necessary due to changes in Cargo that have happened since they were originally incepted.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we continue to add more crates to the compiler and use them to implement
various features we want to be sure we're not accidentally expanding the API
surface area of the compiler! To that end this commit adds a new
run-maketestwhich will attempt to
extern crate fooall crates in the sysroot, verifyingthat they're all unstable.
This commit discovered that the
std_shimandtest_shimcrates wereaccidentally stable and fixes the situation by deleting those shims. The shims
are no longer necessary due to changes in Cargo that have happened since they
were originally incepted.