-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make codemap byte-oriented, simpler #3992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r+ if you can explain a bit about how absolute byte positions work, if we're scanning multiple files (esp. in parallel in the future?) It seems to me a little wonky if this forces us to consider a crate as a contiguous source stream, but I might be misinterpreting what I see. Excellent work in terms of careful transition, otherwise. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 10, 2024
Android: Added syscall support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @graydon
This is preparation for #2176
This series makes the codemap completely byte-oriented, only converting to char offsets on demand. This is necessary so that the parser doesn't have to 'map' an entire file at a time before beginning parsing of other files (future parser changes will require immediately starting another parser when they hit 'mod foo;' statements).
As a bonus, this modernizes the style of codemap, using proper naming conventions, object-orientation, makes it more typesafe by adding types for byte positions and char positions, makes the interaction between Parsers and the CodeMap less error prone by moving all responsibility for managing offsets between FileMaps directly into the CodeMap, probably fixes some lurking bugs in
include!
.There are a lot steps here but the real action is in 81d2015, which does the conversion to using byte offsets for spans.
The remaining complexity, dealing with the
FileSubstr
type, should disappear with#ast
.