Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable Bindings possible nitpick #39923

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Variable Bindings possible nitpick #39923

merged 1 commit into from
Feb 20, 2017
+1 −1

Conversation

mattyw
Copy link
Contributor

@mattyw mattyw commented Feb 18, 2017

Complete drive by nitpick I'm afraid

@mattyw
Variable Bindings possible nitpick
5fa50d9 
Complete drive by nitpick I'm afraid
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thank you! Nitpicks are good 😄

@bors
Copy link
Collaborator

bors commented Feb 19, 2017

📌 Commit 5fa50d9 has been approved by steveklabnik

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 19, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39923 - mattyw:patch-1, r=steveklabnik

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4855fd8 
Variable Bindings possible nitpick

Complete drive by nitpick I'm afraid
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 19, 2017
Closed
@bors
Copy link
Collaborator

bors commented Feb 19, 2017

⌛ Testing commit 5fa50d9 with merge 63ddc10...

@bors
Copy link
Collaborator

bors commented Feb 19, 2017

💔 Test failed - status-travis

@steveklabnik
Copy link
Member

@bors: retry

this seems spurious

@bors
Copy link
Collaborator

bors commented Feb 20, 2017

⌛ Testing commit 5fa50d9 with merge 941d494...

bors added a commit that referenced this pull request Feb 20, 2017
@bors
Auto merge of #39923 - mattyw:patch-1, r=steveklabnik

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
941d494 
Variable Bindings possible nitpick

Complete drive by nitpick I'm afraid
@bors
Copy link
Collaborator

bors commented Feb 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 941d494 to master...

@bors bors merged commit 5fa50d9 into rust-lang:master Feb 20, 2017
@mattyw mattyw deleted the patch-1 branch February 20, 2017 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattyw @rust-highfive @steveklabnik @bors