Publish docs for the proc_macro crate #39986
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
SimonSapin
force-pushed
the
proc_macros-docs
branch
from
b5df817
to
1291727
Compare
SimonSapin
changed the title
src/bootstrap/doc.rs
Outdated
| @@ -162,7 +162,7 @@ pub fn std(build: &Build, stage: u32, target: &str) { | |||
| cargo.arg("-p").arg("std"); | |||
| } else { | |||
| cargo.arg("--no-deps"); | |||
| for krate in &["alloc", "collections", "core", "std", "std_unicode"] { | |||
| for krate in &["alloc", "collections", "core", "std", "std_unicode", "proc_macro"] { | |||
There was a problem hiding this comment.
Shouldn't this be a const near the top of the file instead of a magic number / magic slice?
|
I've tested it, it works! |
SimonSapin
force-pushed
the
proc_macros-docs
branch
from
1291727
to
2a98fc6
Compare
|
I believe the To build docs for proc_macro we'd likely need to add a new step, add a dependency to building libtest, and then add a new function for generating the docs for proc_macro (FWIW much of this I believe is evidenced from the current failure on Travis) |
|
I made this PR as a drive-by on the assumption it was a one-line fix, but it sounds like it’ll require more time that I’m willing to spend on this. So anyone feel free to take this over. |
|
Ok, in that case I'll close this for now (to help clear out the queue), but we can always reopen if necessary |
Fix #38749