Rollup of 11 pull requests #40072
Merged
Rollup of 11 pull requests #40072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 24, 2017
GuillaumeGomez
commented
- Successful merges: book: binary prefixed are defined by IEC and not in SI #39777, enable tools to use test runners programmatically #39815, Add Documentation for Custom Attributes and Error Reporting in Procedural Macros #39845, Additional docs for Vec, String, and slice trait impls #39886, Fix indentation of error message #39940, Add missing urls and examples into Barrier structs #40010, Clarify thread::Builder::stack_size docs #40030, Update std::fmt module docs for landing of #33642. #40048, Update exception-safety.md #40050, Add missing urls in MutexGuard docs #40052, Correct another typo in procedural macros chapter of the Book. #40071
- Failed merges:
Binary prefixes (such as Gi for ‘gibi-’ in GiB) are defined by International Electrotechnical Commission (IEC) and not in the International System of Units (SI).
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
Fix variable name typo
book: binary prefixed are defined by IEC and not in SI Binary prefixes (such as Gi for ‘gibi-’ in GiB) are defined by International Electrotechnical Commission (IEC) and not in the International System of Units (SI). Though to be honest I’d just reword the previous paragraph to use ‘1 GiB’.
enable tools to use test runners programmatically
Add Documentation for Custom Attributes and Error Reporting in Procedural Macros This fixes rust-lang#39821 . I'm not sure if the process of how to access custom attributes should be documented as well. But I feel, that this should rather be documented in `syn`
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
…sxcv Add missing urls and examples into Barrier structs r? @frewsxcv
Clarify thread::Builder::stack_size docs Add two pieces of information: * the size is in bytes * the actual stack size might be bigger. Also change the example to use a more realistic value of 32 kilobytes. r? @steveklabnik
…crichton Update std::fmt module docs for landing of rust-lang#33642. Since rust-lang#33642, it's no longer true that all references to a given format argument must use the same type. The docs don't seem to have been updated.
Update exception-safety.md Fix variable name typo
Add missing urls in MutexGuard docs r? @frewsxcv
…s, r=GuillaumeGomez Correct another typo in procedural macros chapter of the Book. Another (and the only remaining) instance of the lets/let's mistake fixed in c8292fc / 36b00cf. r? @steveklabnik
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10 |
|
📌 Commit f26bbb3 has been approved by |
|
⌛ Testing commit f26bbb3 with merge 8e13567... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit f26bbb3 with merge b0cb0bc... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.