Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Make more network requests retryable #40112

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Feb 26, 2017

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton changed the title travis: Try to perform network requests in one step travis: Make more network requests retryable Feb 26, 2017
@alexcrichton
Copy link
Member Author

@bors: r=brson p=1

@bors
Copy link
Contributor

bors commented Feb 26, 2017

📌 Commit fc1ac9c has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 26, 2017

⌛ Testing commit fc1ac9c with merge bc62b9b...

@bors
Copy link
Contributor

bors commented Feb 26, 2017

💔 Test failed - status-travis

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Feb 26, 2017

📌 Commit c08f382 has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 26, 2017

⌛ Testing commit c08f382 with merge 44e9e0a...

bors added a commit that referenced this pull request Feb 26, 2017
 travis: Make more network requests retryable

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!
function retry {
local n=1
local max=5
local delay=15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable

@bors
Copy link
Contributor

bors commented Feb 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 44e9e0a to master...

@bors bors merged commit c08f382 into rust-lang:master Feb 26, 2017
@alexcrichton alexcrichton deleted the fetch-all branch March 8, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants