-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move two large error_reporting fn's to a separate file #40128
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit d21b0e3 has been approved by |
@bors r+ |
📌 Commit 2f8ef50 has been approved by |
@bors r+ |
📌 Commit e136bf6 has been approved by |
Move two large error_reporting fn's to a separate file Hello! I tried to make `librustc/infer/error_reporting,rs` more readable by modularizing it and moving its two largest functions to a separate file. If you have any suggestions, please send it right away! 🚀 Thanks goes to @nikomatsakis for supporting.
Hello!
I tried to make
librustc/infer/error_reporting,rs
more readable by modularizing it and moving its two largest functions to a separate file.If you have any suggestions, please send it right away! 🚀
Thanks goes to @nikomatsakis for supporting.