Rollup of 9 pull requests #40148
Rollup of 9 pull requests #40148
Conversation
frewsxcv
commented
Feb 28, 2017
frewsxcv
commented
- Successful merges: librustc error_reporting.rs cleanup. #39977, Add missing urls and examples for Condvar docs #40033, Add compile fail test for unboxed_closures feature #40047, Replace ./configure with config.toml in README.md and CONTRIBUTING.md #40056, Fix nightly-only experimental API display #40057, Example for how to provide stdin using std::process::Command #40122, Remove unnecessary "for" #40124, Add missing docs and examples for fmt::Write #40126, Make lifetime elision docs clearer #40131
- Failed merges: Add compile fail test for SIMD #40101
Spawning a child process and writing to its stdin is a bit tricky due to `as_mut` and having to use a limited borrow. An example for this might help newer users.
…=eddyb librustc error_reporting.rs cleanup. Read some code in librustc, mainly in error_reporting.rs, and cleaned up some things along the way. I recommend looking at each commit individually or looking at the [whitespace insensitive diff](https://github.com/rust-lang/rust/pull/39977/files?w=1).
…sxcv Add missing urls and examples for Condvar docs r? @frewsxcv
Add compile fail test for unboxed_closures feature Hello, this is my first contribution to rust. Issue rust-lang#39059.
…crichton Replace ./configure with config.toml in README.md and CONTRIBUTING.md Replace ./configure with config.toml in README.md and CONTRIBUTING.md, so that new users aren't confused about which build system to use, and how to configure the build process.
Fix nightly-only experimental API display Before: <img width="1440" alt="screen shot 2017-02-23 at 12 53 09" src="https://cloud.githubusercontent.com/assets/3050060/23258119/0c9cf6f2-f9c7-11e6-9989-15b4346dade0.png"> After: <img width="1440" alt="screen shot 2017-02-23 at 12 51 40" src="https://cloud.githubusercontent.com/assets/3050060/23258076/e6881118-f9c6-11e6-826c-442a73502b59.png"> r? @frewsxcv
…ting-to-stdin, r=alexcrichton Example for how to provide stdin using std::process::Command Spawning a child process and writing to its stdin is a bit tricky due to `as_mut` and having to use a limited borrow. An example for this might help newer users. r? @steveklabnik
Remove unnecessary "for"
…ewsxcv Add missing docs and examples for fmt::Write r? @frewsxcv
Make lifetime elision docs clearer Previously it said "It's forbidden to allow reasoning about types based on the item signature alone." I think that sentence is wrong. Rust **uses** the item signatures to perform type inference within the body. I think what's meant is the other way around: It does not infer types for item signatures. r? @steveklabnik
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit a851fc1 has been approved by |
|
⌛ Testing commit a851fc1 with merge 31bd0c6... |
|
💔 Test failed - status-appveyor |
|
@bors retry weird windows permissions issue? |
|
⌛ Testing commit a851fc1 with merge be76056... |
|
@frewsxcv You should |
|
☀️ Test successful - status-appveyor, status-travis |
