Implement least-upper-bound for fn types #4015
Closed
+705
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still haven't read the LUB patch yet. |
|
r+. though I am yet to understand it, I don't want to keep holding you up |
|
Yeah the algorithm is...dense. I've been trying to write-up a good justification of why I think its correct. Maybe we can discuss in person. Even presuming that we don't uncover a flaw :), such a discussion would help me to figure out how best to explain it. |
|
Pushed. |
|
Reopening to remind me to finish reading this. |
|
I'm going to stop reviewing this now. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Improve compile_test and dogfood tests * Hopefully this finally resolves the "multiple matching crates" error, e.g. rust-lang#4015 * This handle some convenient CARGO env like CARGO_TARGET_DIR and CARGO_BUILD_TARGET changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson