Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for 'E-needstest' labeled issues #40276

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Mar 5, 2017

This PR adds missing tests for issue #35988, #19712, #18627, #24947, #28600 and #34751.

Fixes #35988
Fixes #19712
Fixes #24947
Fixes #28600
Fixes #34751

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrochenkov
Copy link
Contributor

@topecongiro
Could you remove the test for #18627? It's not actually fixed.

@topecongiro
Copy link
Contributor Author

Removed the test for #18627 & rebased.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2017

📌 Commit a54f9dd has been approved by petrochenkov

@bors
Copy link
Collaborator

bors commented Mar 6, 2017

⌛ Testing commit a54f9dd with merge 11bc48a...

bors added a commit that referenced this pull request Mar 6, 2017
Add missing tests for 'E-needstest' labeled issues

This PR adds missing tests for issue #35988, #19712, ~~#18627~~, #24947, #28600 and #34751.
@bors
Copy link
Collaborator

bors commented Mar 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 11bc48a to master...

@bors bors merged commit a54f9dd into rust-lang:master Mar 6, 2017
@brson
Copy link
Contributor

brson commented Apr 25, 2017

Awesome PR @topecongiro 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants