Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: expose LLVM_PARALLEL_LINK_JOBS #40277

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

hanna-kruppe
Copy link
Contributor

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@hanna-kruppe
Copy link
Contributor Author

r? @alexcrichton

NB: This is untested, because rebuilding LLVM is a hassle on the machine I'm currently on (and MSVC may ignore it anyway).

@rust-highfive rust-highfive assigned alexcrichton and unassigned brson Mar 5, 2017
@Mark-Simulacrum
Copy link
Member

For me, linking LLVM in parallel (-j8 for my number of cores) consumes more than 8 GB of memory, while building it never consumes more than ~2 GB, so it would be very nice to be able to build quickly (in parallel) but not link in parallel.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 6, 2017

📌 Commit 202d8da has been approved by alexcrichton

@alexcrichton
Copy link
Member

Thanks @rkruppe!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@bors
Copy link
Contributor

bors commented Mar 9, 2017

🔒 Merge conflict

This allows limiting the number of linker jobs to avoid swapping when
linking LLVM with debug info.
@hanna-kruppe hanna-kruppe force-pushed the llvm-parallel-link-jobs branch from 202d8da to 58ff4f6 Compare March 9, 2017 14:08
@hanna-kruppe
Copy link
Contributor Author

hanna-kruppe commented Mar 9, 2017

I have no idea what this "merge conflict" is about, I just rebased without conflicts?! Maybe that unwedges bors ¯\_(ツ)_/¯

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 9, 2017

📌 Commit 58ff4f6 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…alexcrichton

rustbuild: expose LLVM_PARALLEL_LINK_JOBS

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@bors bors merged commit 58ff4f6 into rust-lang:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants