Rollup of 5 pull requests #40302
Closed
Rollup of 5 pull requests #40302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Mar 6, 2017
GuillaumeGomez
commented
- Successful merges: Extract nomicon to its own repo #40222, Issue #39688 - Help people find String::as_bytes() for UTF-8 #40226, clarify docs for Args and ArgsOs #40283, Fix text formatting in README #40292, Remove extra space in test description (of a mod test) #40293
- Failed merges:
The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
Issue rust-lang#39688 - Help people find String::as_bytes() for UTF-8 Added in links for the inverse functions so people will know that as_bytes() is the inverse of from_utf8() and vice versa. ?r @steveklabnik
clarify docs for Args and ArgsOs The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
Fix text formatting in README There was a missing backtick in the README.
Remove extra space in test description (of a mod test)
|
@bors: r+ p=1 |
|
📌 Commit 10d8d68 has been approved by |
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 10d8d68 with merge 34b5c05... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit 10d8d68 with merge 17c57ce... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit 10d8d68 with merge 87227c8... |
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.