Fix documentation for Vec::dedup_by. #40536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
suggested changes
Mar 15, 2017
src/libcollections/vec.rs
Outdated
| @@ -838,7 +838,11 @@ impl<T> Vec<T> { | |||
| self.dedup_by(|a, b| key(a) == key(b)) | |||
| } | |||
|
|
|||
| /// Removes consecutive elements in the vector that resolve to the same key. | |||
| /// Removes consecutive elements in the vector that compare equal according to a predicate. | |||
There was a problem hiding this comment.
Could you remove that compare equal? It's a bit awkward here, and this is the summary line.
The previous docstring was copied from dedup_by_key.
kevinmehall
force-pushed
the
dedup_docs_for_dedup_by
branch
from
fb45ee3
to
e66b3a2
Compare
steveklabnik
approved these changes
Mar 15, 2017
|
@bors: r+ rollup thanks! |
|
📌 Commit e66b3a2 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous docstring was copied from dedup_by_key.