[beta] std: Back out backtrace pruning logic on beta #40684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered rust-lang#40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle rust-lang#40264 this commit backs out the changes on beta to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
alexcrichton
added
the
T-libs-api
|
@bors r+ |
|
📌 Commit 810fd29 has been approved by |
|
💔 Test failed - status-travis |
The emsdk-portable .tar.gz now extracts to emsdk-portable instead of emsdk_portable. Handle that.
|
@bors: r=brson |
|
📌 Commit 7573111 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 27, 2017
[beta] std: Back out backtrace pruning logic on beta It was discovered #40264 that this backtrace pruning logic is a little too aggressive, so while we figure how out to handle #40264 this commit backs out the changes on beta to prune frames. Note that other cosmetic changes, such as better path printing and such remain.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered #40264 that this backtrace pruning logic is a little too
aggressive, so while we figure how out to handle #40264 this commit backs out
the changes on beta to prune frames. Note that other cosmetic changes, such as
better path printing and such remain.