Suggest using enum when a variant is used as a type #40775

estebank · 2017-03-23T22:17:50Z

Given a file:

enum Fruit {
    Apple(i64),
    Orange(i64),
}

fn should_return_fruit() -> Apple {
    Apple(5)
}

Provide the following output:

error[E0412]: cannot find type `Apple` in this scope
  --> file.rs:16:29
   |
16 | fn should_return_fruit() -> Apple {
   |                             ^^^^^ not found in this scope
   |
help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
  --> file.rs:12:5
   |
12 |     Apple(i64),
   |     ^^^^^^^^^^

error[E0425]: cannot find function `Apple` in this scope
  --> file.rs:17:5
   |
17 |     Apple(5)
   |     ^^^^^ not found in this scope
   |
   = help: possible candidate is found in another module, you can import it into scope:
             `use Fruit::Apple;`

Fix #35675.

rust-highfive · 2017-03-23T22:17:54Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2017-03-24T06:39:45Z

r? @petrochenkov

petrochenkov · 2017-03-24T22:06:27Z

src/librustc_resolve/lib.rs

@@ -2266,6 +2266,24 @@ impl<'a> Resolver<'a> {
            if !candidates.is_empty() {
                // Report import candidates as help and proceed searching for labels.
                show_candidates(&mut err, &candidates, def.is_some());
+            } else {


This else block should run only if is_expected(Def::Enum) is true.

Could you also move this logic into a separate function?

Could you add an UI test where the found enum is not in scope? How does X in "did you mean to use X?" look in this case?

petrochenkov · 2017-03-24T22:17:37Z

This patch covers the case "no resolution found -> candidate variants found elsewhere -> enums of these variants are suggested".
But there's also "resolution is found and it's a variant -> enum of this variant is suggested". Could you add this as well?
It needs to be added into the "// Try context dependent help ..." section below and reported as a label.

estebank · 2017-03-29T04:19:23Z

I believe all cases are handled now, but the wording for the standard enums is a bit rough as it stands now:

error[E0573]: expected type, found variant `Some`
  --> $DIR/issue-35675.rs:27:13
   |
27 | fn qux() -> Some {
   |             ^^^^ not a type
   |
   = help: there is an enum variant `std::prelude::v1::Some`, did you mean to use `std::prelude::v1`?
   = help: there is an enum variant `std::prelude::v1::Option::Some`, did you mean to use `std::prelude::v1::Option`?

petrochenkov · 2017-03-29T23:14:00Z

@estebank

help: there is an enum variant std::prelude::v1::Some, did you mean to use std::prelude::v1?

You can use resolve_path on the suggested path and check if the result is enum.

Could you also add a test for #40775 (comment)?
Something like

enum Enum { Variant }

fn f() -> Enum::Variant // successfully resolved to variant, but enum is expected
{ ... }

estebank · 2017-04-02T16:02:39Z

@petrochenkov done.

Given a file: ```rust enum Fruit { Apple(i64), Orange(i64), } fn should_return_fruit() -> Apple { Apple(5) } ``` Provide the following output: ```rust error[E0412]: cannot find type `Apple` in this scope --> file.rs:16:29 | 16 | fn should_return_fruit() -> Apple { | ^^^^^ not found in this scope | help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`? --> file.rs:12:5 | 12 | Apple(i64), | ^^^^^^^^^^ error[E0425]: cannot find function `Apple` in this scope --> file.rs:17:5 | 17 | Apple(5) | ^^^^^ not found in this scope | = help: possible candidate is found in another module, you can import it into scope: `use Fruit::Apple;` ```

petrochenkov · 2017-04-03T08:33:14Z

Travis failure in UI tests, otherwise r=me

estebank · 2017-04-03T23:01:53Z

@bors r=petrochenkov

bors · 2017-04-03T23:01:54Z

📌 Commit 73f6f5e has been approved by petrochenkov

bors · 2017-04-05T08:34:18Z

⌛ Testing commit 73f6f5e with merge 6700cf9...

bors · 2017-04-05T09:04:08Z

💔 Test failed - status-travis

estebank · 2017-04-05T12:05:39Z

@bors retry

…enkov Suggest using enum when a variant is used as a type Given a file: ```rust enum Fruit { Apple(i64), Orange(i64), } fn should_return_fruit() -> Apple { Apple(5) } ``` Provide the following output: ```rust error[E0412]: cannot find type `Apple` in this scope --> file.rs:16:29 | 16 | fn should_return_fruit() -> Apple { | ^^^^^ not found in this scope | help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`? --> file.rs:12:5 | 12 | Apple(i64), | ^^^^^^^^^^ error[E0425]: cannot find function `Apple` in this scope --> file.rs:17:5 | 17 | Apple(5) | ^^^^^ not found in this scope | = help: possible candidate is found in another module, you can import it into scope: `use Fruit::Apple;` ``` Fix rust-lang#35675.

arielb1 · 2017-04-05T22:59:05Z

Travis failure:


[01:07:19] failures:
[01:07:19] thread 'main' panicked at 'Some tests failed', /checkout/src/tools/compiletest/src/main.rs:329
[01:07:19] 
[01:07:19] ---- [ui] ui/did_you_mean/issue-35675.rs stdout ----
[01:07:19] 	ui: /checkout/src/test/ui/did_you_mean/issue-35675.rs
[01:07:19] normalized stderr:
[01:07:19] error[E0412]: cannot find type `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:16:29
[01:07:19]    |
[01:07:19] 16 | fn should_return_fruit() -> Apple {
[01:07:19]    |                             ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> $DIR/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:17:5
[01:07:19]    |
[01:07:19] 17 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Fruit::Apple`
[01:07:19]   --> $DIR/issue-35675.rs:20:33
[01:07:19]    |
[01:07:19] 20 | fn should_return_fruit_too() -> Fruit::Apple {
[01:07:19]    |                                 ^^^^^^^^^^^^ not a type
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> $DIR/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:21:5
[01:07:19]    |
[01:07:19] 21 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Ok`
[01:07:19]   --> $DIR/issue-35675.rs:24:13
[01:07:19]    |
[01:07:19] 24 | fn foo() -> Ok {
[01:07:19]    |             ^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Ok`, did you mean to use `std::prelude::v1`?
[01:07:19]    = help: there is an enum variant `std::result::Result::Ok`, did you mean to use `std::result::Result`?
[01:07:19] 
[01:07:19] error[E0412]: cannot find type `Variant3` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:28:13
[01:07:19]    |
[01:07:19] 28 | fn bar() -> Variant3 {
[01:07:19]    |             ^^^^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `x::Enum::Variant3`, did you mean to use `x::Enum`?
[01:07:19]   --> $DIR/issue-35675.rs:41:9
[01:07:19]    |
[01:07:19] 41 |         Variant3(usize),
[01:07:19]    |         ^^^^^^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Some`
[01:07:19]   --> $DIR/issue-35675.rs:31:13
[01:07:19]    |
[01:07:19] 31 | fn qux() -> Some {
[01:07:19]    |             ^^^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Option::Some`, did you mean to use `std::prelude::v1::Option`?
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Some`, did you mean to use `std::prelude::v1`?
[01:07:19] 
[01:07:19] error: aborting due to 7 previous errors
[01:07:19] 
[01:07:19] 
[01:07:19] 
[01:07:19] expected stderr:
[01:07:19] error[E0412]: cannot find type `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:16:29
[01:07:19]    |
[01:07:19] 16 | fn should_return_fruit() -> Apple {
[01:07:19]    |                             ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> $DIR/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:17:5
[01:07:19]    |
[01:07:19] 17 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Fruit::Apple`
[01:07:19]   --> $DIR/issue-35675.rs:20:33
[01:07:19]    |
[01:07:19] 20 | fn should_return_fruit_too() -> Fruit::Apple {
[01:07:19]    |                                 ^^^^^^^^^^^^ not a type
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> $DIR/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:21:5
[01:07:19]    |
[01:07:19] 21 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Ok`
[01:07:19]   --> $DIR/issue-35675.rs:24:13
[01:07:19]    |
[01:07:19] 24 | fn foo() -> Ok {
[01:07:19]    |             ^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Ok`, did you mean to use `std::prelude::v1`?
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Result::Ok`, did you mean to use `std::prelude::v1::Result`?
[01:07:19] 
[01:07:19] error[E0412]: cannot find type `Variant3` in this scope
[01:07:19]   --> $DIR/issue-35675.rs:28:13
[01:07:19]    |
[01:07:19] 28 | fn bar() -> Variant3 {
[01:07:19]    |             ^^^^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `x::Enum::Variant3`, did you mean to use `x::Enum`?
[01:07:19]   --> $DIR/issue-35675.rs:41:9
[01:07:19]    |
[01:07:19] 41 |         Variant3(usize),
[01:07:19]    |         ^^^^^^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Some`
[01:07:19]   --> $DIR/issue-35675.rs:31:13
[01:07:19]    |
[01:07:19] 31 | fn qux() -> Some {
[01:07:19]    |             ^^^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Option::Some`, did you mean to use `std::prelude::v1::Option`?
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Some`, did you mean to use `std::prelude::v1`?
[01:07:19] 
[01:07:19] error: aborting due to 7 previous errors
[01:07:19] 
[01:07:19] 
[01:07:19] 
[01:07:19] diff of stderr:
[01:07:19] 
[01:07:19]  49 - |   = help: there is an enum variant `std::prelude::v1::Result::Ok`, did you mean to use `std::prelude::v1::Result`?|
[01:07:19]     + |   = help: there is an enum variant `std::result::Result::Ok`, did you mean to use `std::result::Result`?|
[01:07:19] 
[01:07:19] 
[01:07:19] The actual stderr differed from the expected stderr.
[01:07:19] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/issue-35675.stderr
[01:07:19] To update references, run this command from build directory:
[01:07:19] /checkout/src/test/ui/update-references.sh '/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui' 'did_you_mean/issue-35675.rs'
[01:07:19] 
[01:07:19] error: 1 errors occurred comparing output.
[01:07:19] status: exit code: 101
[01:07:19] command: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /checkout/src/test/ui/did_you_mean/issue-35675.rs -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui --target=x86_64-unknown-linux-gnu -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/issue-35675.stage2-x86_64-unknown-linux-gnu.ui.libaux -C prefer-dynamic -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/issue-35675.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers
[01:07:19] stdout:
[01:07:19] ------------------------------------------
[01:07:19] 
[01:07:19] ------------------------------------------
[01:07:19] stderr:
[01:07:19] ------------------------------------------
[01:07:19] error[E0412]: cannot find type `Apple` in this scope
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:16:29
[01:07:19]    |
[01:07:19] 16 | fn should_return_fruit() -> Apple {
[01:07:19]    |                             ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:17:5
[01:07:19]    |
[01:07:19] 17 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Fruit::Apple`
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:20:33
[01:07:19]    |
[01:07:19] 20 | fn should_return_fruit_too() -> Fruit::Apple {
[01:07:19]    |                                 ^^^^^^^^^^^^ not a type
[01:07:19]    |
[01:07:19] help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`?
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:12:5
[01:07:19]    |
[01:07:19] 12 |     Apple(i64),
[01:07:19]    |     ^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0425]: cannot find function `Apple` in this scope
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:21:5
[01:07:19]    |
[01:07:19] 21 |     Apple(5)
[01:07:19]    |     ^^^^^ not found in this scope
[01:07:19]    |
[01:07:19]    = help: possible candidate is found in another module, you can import it into scope:
[01:07:19]              `use Fruit::Apple;`
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Ok`
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:24:13
[01:07:19]    |
[01:07:19] 24 | fn foo() -> Ok {
[01:07:19]    |             ^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Ok`, did you mean to use `std::prelude::v1`?
[01:07:19]    = help: there is an enum variant `std::result::Result::Ok`, did you mean to use `std::result::Result`?
[01:07:19] 
[01:07:19] error[E0412]: cannot find type `Variant3` in this scope
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:28:13
[01:07:19]    |
[01:07:19] 28 | fn bar() -> Variant3 {
[01:07:19]    |             ^^^^^^^^ not found in this scope
[01:07:19]    |
[01:07:19] help: there is an enum variant `x::Enum::Variant3`, did you mean to use `x::Enum`?
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:41:9
[01:07:19]    |
[01:07:19] 41 |         Variant3(usize),
[01:07:19]    |         ^^^^^^^^^^^^^^^
[01:07:19] 
[01:07:19] error[E0573]: expected type, found variant `Some`
[01:07:19]   --> /checkout/src/test/ui/did_you_mean/issue-35675.rs:31:13
[01:07:19]    |
[01:07:19] 31 | fn qux() -> Some {
[01:07:19]    |             ^^^^ not a type
[01:07:19]    |
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Option::Some`, did you mean to use `std::prelude::v1::Option`?
[01:07:19]    = help: there is an enum variant `std::prelude::v1::Some`, did you mean to use `std::prelude::v1`?
[01:07:19] 
[01:07:19] error: aborting due to 7 previous errors
[01:07:19] 
[01:07:19] 
[01:07:19] ------------------------------------------
[01:07:19] 
[01:07:19] thread '[ui] ui/did_you_mean/issue-35675.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2621
[01:07:19] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:07:19] 
[01:07:19] 
[01:07:19] failures:
[01:07:19]     [ui] ui/did_you_mean/issue-35675.rs
[01:07:19] 
[01:07:19] test result: FAILED. 240 passed; 1 failed; 1 ignored; 0 measured
[01:07:19] 
[01:07:19] 
[01:07:19] 
[01:07:19] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.7/bin/FileCheck" "--host-rustcflags" "-Crpath -O" "--target-rustcflags" "-Crpath -O -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "3.7.1\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp" "--android-cross-path" ""
[01:07:19] expected success, got: exit code: 101
[01:07:19] 
[01:07:19] 
[01:07:19] Build completed unsuccessfully in 0:31:54
[01:07:19] make: *** [check] Error 1
[01:07:19] Makefile:54: recipe for target 'check' failed

@bors r-

estebank · 2017-04-07T15:00:29Z

@arielb1 the stderr output of that file differs between my local system and the different travis environments. Is there a way to have fuzzy matching on the UI tests? On the compile-fail tests you can get away with matching only the beginning of the text. If there isn't that feature for UI tests, I'll just move these to cfail.

estebank · 2017-04-08T08:06:28Z

Moved tests to cfail.

@bors r=petrochenkov

bors · 2017-04-08T08:06:29Z

📌 Commit 2b2eeda has been approved by petrochenkov

bors · 2017-04-08T09:23:35Z

⌛ Testing commit 2b2eeda with merge 4cadff6...

Suggest using enum when a variant is used as a type Given a file: ```rust enum Fruit { Apple(i64), Orange(i64), } fn should_return_fruit() -> Apple { Apple(5) } ``` Provide the following output: ```rust error[E0412]: cannot find type `Apple` in this scope --> file.rs:16:29 | 16 | fn should_return_fruit() -> Apple { | ^^^^^ not found in this scope | help: there is an enum variant `Fruit::Apple`, did you mean to use `Fruit`? --> file.rs:12:5 | 12 | Apple(i64), | ^^^^^^^^^^ error[E0425]: cannot find function `Apple` in this scope --> file.rs:17:5 | 17 | Apple(5) | ^^^^^ not found in this scope | = help: possible candidate is found in another module, you can import it into scope: `use Fruit::Apple;` ``` Fix #35675.

bors · 2017-04-08T11:47:44Z

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 4cadff6 to master...

rust-highfive assigned arielb1 Mar 23, 2017

estebank force-pushed the variant-as-type branch from ee5cd9e to d7b5c35 Compare March 23, 2017 22:18

petrochenkov assigned petrochenkov and unassigned arielb1 Mar 24, 2017

petrochenkov reviewed Mar 24, 2017

View reviewed changes

estebank force-pushed the variant-as-type branch from 7b1fa66 to 44d7726 Compare March 29, 2017 06:17

estebank force-pushed the variant-as-type branch from 44d7726 to 30c544a Compare April 2, 2017 16:02

estebank force-pushed the variant-as-type branch from 30c544a to 9e835b5 Compare April 2, 2017 16:33

estebank force-pushed the variant-as-type branch from 9e835b5 to b946ecd Compare April 2, 2017 16:34

Sort enum suggestions

73f6f5e

estebank force-pushed the variant-as-type branch from 3a92c50 to 73f6f5e Compare April 3, 2017 17:57

frewsxcv mentioned this pull request Apr 5, 2017

Rollup of 9 pull requests #41093

Closed

arielb1 mentioned this pull request Apr 5, 2017

Rollup of 12 pull requests #41094

Closed

Move tests from ui to cfail

2b2eeda

estebank force-pushed the variant-as-type branch from d936b90 to 2b2eeda Compare April 8, 2017 00:23

bors merged commit 2b2eeda into rust-lang:master Apr 8, 2017

petrochenkov mentioned this pull request May 16, 2017

Change some notes into suggestions #42033

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest using enum when a variant is used as a type #40775

Suggest using enum when a variant is used as a type #40775

estebank commented Mar 23, 2017

rust-highfive commented Mar 23, 2017

petrochenkov commented Mar 24, 2017

petrochenkov Mar 24, 2017

petrochenkov Mar 24, 2017

petrochenkov Mar 24, 2017

petrochenkov commented Mar 24, 2017

estebank commented Mar 29, 2017

petrochenkov commented Mar 29, 2017

estebank commented Apr 2, 2017

petrochenkov commented Apr 3, 2017

estebank commented Apr 3, 2017

bors commented Apr 3, 2017

bors commented Apr 5, 2017

bors commented Apr 5, 2017

estebank commented Apr 5, 2017

arielb1 commented Apr 5, 2017

estebank commented Apr 7, 2017

estebank commented Apr 8, 2017

bors commented Apr 8, 2017

bors commented Apr 8, 2017

bors commented Apr 8, 2017

Suggest using enum when a variant is used as a type #40775

Suggest using enum when a variant is used as a type #40775

Conversation

estebank commented Mar 23, 2017

rust-highfive commented Mar 23, 2017

petrochenkov commented Mar 24, 2017

petrochenkov Mar 24, 2017

Choose a reason for hiding this comment

petrochenkov Mar 24, 2017

Choose a reason for hiding this comment

petrochenkov Mar 24, 2017

Choose a reason for hiding this comment

petrochenkov commented Mar 24, 2017

estebank commented Mar 29, 2017

petrochenkov commented Mar 29, 2017

estebank commented Apr 2, 2017

petrochenkov commented Apr 3, 2017

estebank commented Apr 3, 2017

bors commented Apr 3, 2017

bors commented Apr 5, 2017

bors commented Apr 5, 2017

estebank commented Apr 5, 2017

arielb1 commented Apr 5, 2017

estebank commented Apr 7, 2017

estebank commented Apr 8, 2017

bors commented Apr 8, 2017

bors commented Apr 8, 2017

bors commented Apr 8, 2017