-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit proper lifetime start intrinsics for personality slots #40908
Conversation
We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 1eaa113 has been approved by |
⌛ Testing commit 1eaa113 with merge d425d23... |
💔 Test failed - status-appveyor |
Exception handling on MSVC targets doesn't use personality slots.
Disabled the test on MSVC which doesn't use personality slots. |
@bors r+ |
📌 Commit 0ba7da3 has been approved by |
⌛ Testing commit 0ba7da3 with merge 773d1ea... |
💔 Test failed - status-travis |
… On Sat, Apr 1, 2017 at 7:10 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/217513825>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40908 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FJhINx6O8E3D_PbfyXkO8UdqFciks5rrkyxgaJpZM4MtZcU>
.
|
Emit proper lifetime start intrinsics for personality slots We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.
💔 Test failed - status-appveyor |
@bors: retry
|
⌛ Testing commit 0ba7da3 with merge c684503... |
💔 Test failed - status-appveyor |
Is that a spurious error? That build completed in the previous run. |
Let's see @bors retry |
Failure is:
|
⌛ Testing commit 0ba7da3 with merge 9a388b8... |
💔 Test failed - status-travis |
… On Mon, Apr 3, 2017 at 2:10 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/218210808>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40908 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PoSTnLKtKNXOSTR3D5BkDSRA_WAks5rsVIigaJpZM4MtZcU>
.
|
Emit proper lifetime start intrinsics for personality slots We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.
Emit proper lifetime start intrinsics for personality slots We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.
We currently only emit a single call to the lifetime start intrinsic
for the personality slot alloca. This happens because we create that
call at the time that we create the alloca, instead of creating it each
time we start using it. Because LLVM usually removes the alloca before
the lifetime intrinsics are even considered, this didn't cause any
problems yet, but we should fix this anyway.