Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DefPath hashing centrally as part of DefPathTable (+ save work during SVH calculation) #41056

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Handle DefPath hashing centrally as part of DefPathTable (+ save work during SVH calculation) #41056

merged 2 commits into from
Apr 7, 2017

Commits on Apr 7, 2017

  1. ICH: Centrally compute and cache DefPath hashes as part of DefPathTable.

    @michaelwoerister
    michaelwoerister committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    edc1ac3 View commit details
    Browse the repository at this point in the history

  2. SVH: Don't hash the HIR twice when once is enough. 

    The SVH (Strict Version Hash) of a crate is currently computed
by hashing the ICHes (Incremental Computation Hashes) of the
crate's HIR. This is fine, expect that for incr. comp. we compute
two ICH values for each HIR item, one for the complete item and
one that just includes the item's interface. The two hashes are
are needed for dependency tracking but if we are compiling
non-incrementally and just need the ICH values for the SVH,
one of them is enough, giving us the opportunity to save some
work in this case.
    @michaelwoerister
    michaelwoerister committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    bb63872 View commit details
    Browse the repository at this point in the history