-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 16 pull requests #41070
Rollup of 16 pull requests #41070
Conversation
This change adds links to to `Receiver`, `Iter`, `TryIter`, `IntoIter`, `Sender`, `SyncSender`, `SendError`, `RecvError`, `TryRecvError`, `RecvTimeoutError`, `TrySendError`, `Sender::send`, `SyncSender::send`, `SyncSender::try_send`, `Receiver::recv`, `Receiver::recv_timeout`, `Receiver::iter`, and `Receiver::try_iter`. Examples added to `Receiver`, `Sender`, `Receiver::iter`.
* Change `utf8` variable names to `non_ascii` to be more clear, since ASCII and UTF-8 are compatible. * Fix `EscapeDefault` struct description to follow the typical iterator method format with a link to the generating function. * Add more `escape_default` examples to cover every case mentioned in the function description itself.
This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closes rust-lang#37499
This reverts commit 2cf686f (rust-lang#40842) RawFd is a type alias for c_int, which is itself a type alias for i32. As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds them for i32. As a result, the reverted commit makes this valid: ``` use std::os::unix::io::AsRawFd; fn arf<T: AsRawFd>(_: T) {} fn main() { arf(32i32) } ``` Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both those traits that their methods return a valid RawFd. r? @aturon cc @Mic92 @kamalmarhubi
part of rust-lang#40912 []\n() is not actually a link.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
💔 Test failed - status-travis |
@bors retry |
⌛ Testing commit ecc9219 with merge 7d4704e... |
💔 Test failed - status-travis |
…ncy, r=steveklabnik Fix mutex's docs inconsistency Fixes rust-lang#40176. r? @steveklabnik cc @rust-lang/docs
…ystem, r=aturon rustc: Stabilize the `#![windows_subsystem]` attribute This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closes rust-lang#37499
Improve some docs for VecDeque r? @GuillaumeGomez
…steveklabnik Updating the description for BarrierWaitResult rust-lang#29377 Referencing `Barrier`, removing reference to `is_leader`.
Add links and some examples to std::sync::mpsc docs Addresses part of rust-lang#29377 r? @steveklabnik I took a stab at adding links to the `std::sync::mpsc` docs, and I also wrote a few examples. Edit: Whoops, typed in `?r` instead of `r?`.
API Docs: ascii Add/update docs for the `ascii` module per rust-lang#29341. r? @steveklabnik
…xcrichton Added links to from_utf8 methods in Utf8Error Referencing rust-lang#29375. Linked the `from_utf8` methods for both `String` and `str` in the description. Also linked the `u8` to its documentation
…teveklabnik Added links to types in from_utf8 description References rust-lang#29375. Link to types mentioned in the documentation for `from_utf8` (`str`, `&[u8`], etc). Paragraphs were reformatted to keep any one line from being excessively long, but are otherwise unchanged.
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
Improve documentation for `std::fs::DirBuilder`
std::thread docs: fix link to current()
…BurntSushi Fixed typo in doc comments for swap_remove While reading the Vec docs, I came across the docs for swap_remove. I believe there is a typo in the comment and ```return``` should be ```returns```. This PR fixes this issue. I also feel that the entire doc comment is a bit of a run-on and could be changed to something along the lines of ```Removes an element from anywhere in the vector and returns it. The vector is mutated and the removed element is replaced by the last element of the vector. ``` Thoughts?
…aturon Revert "Implement AsRawFd/IntoRawFd for RawFd" This reverts commit 2cf686f (rust-lang#40842) RawFd is a type alias for c_int, which is itself a type alias for i32. As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds them for i32. As a result, the reverted commit makes this valid: ``` use std::os::unix::io::AsRawFd; fn arf<T: AsRawFd>(_: T) {} fn main() { arf(32i32) } ``` Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both those traits that their methods return a valid RawFd. r? @aturon cc @Mic92 @kamalmarhubi
…labnik Replace ^ with <sup> html balise r? @steveklabnik
…, r=frewsxcv Handle ordered lists as well Part of rust-lang#40912. r? @rust-lang/docs
Do not recommend private fields called as method ```rust error: no method named `dog_age` found for type `animal::Dog` in the current scope --> $DIR/private-field.rs:26:23 | 26 | let dog_age = dog.dog_age(); | ^^^^^^^ private field, not a method ``` Fix rust-lang#27654.
Fix links part of rust-lang#40912 []\n() is not actually a link. r? @frewsxcv @GuillaumeGomez
…sxcv travis: Update sccache binaries I've tracked down what I believe is the last spurious sccache failure on rust-lang#40240 to behavior in mio (tokio-rs/mio#583), and this commit updates the binaries to a version which has that fix incorporated.
…ichton Properly adjust filenames when multiple emissions Fixes rust-lang#40993 Should backport just fine to beta but not sure if we want to do this since this is quite old stable regression.
#![windows_subsystem]
attribute #40870, Improve some docs for VecDeque #40949, Updating the description for BarrierWaitResult #29377 #40977, Add links and some examples to std::sync::mpsc docs #40981, API Docs: ascii #40988, Added links to from_utf8 methods in Utf8Error #40992, Added links to types in from_utf8 description #40997, Improve option API docs #40999, Improve documentation forstd::fs::DirBuilder
#41007, std::thread docs: fix link to current() #41014, Fixed typo in doc comments for swap_remove #41019, Revert "Implement AsRawFd/IntoRawFd for RawFd" #41035, Replace ^ with <sup> html balise #41043, Handle ordered lists as well #41049