Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test cross compiling core for the thumb targets #41133

Closed
wants to merge 1 commit into from

Conversation

japaric
Copy link
Member

@japaric japaric commented Apr 7, 2017

this commit adds a new path, src/libcore, to bootstrap that (cross) compiles
only the core crate for the target, and a thumb image that will test cross
compiling core for the 4 existing thumb targets.

closes #38828

r? @alexcrichton

I'm not sure if the .travis.yml changes are correct / enough but
./src/ci/docker/run.sh thumb does the core cross compilation test

this commit adds a new path, src/libcore, to bootstrap that (cross) compiles
only the core crate for the target, and a thumb image that will test cross
compiling core for the 4 existing thumb targets.

closes rust-lang#38828
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks @japaric! Would it be possible to avoid duplicating the std function used in rustbuild to compile libstd? The goal was in theory to only have one function that invokes cargo but the std/test/rustc split necessitated three unfortunately, and I was hoping to not grow beyond that.

@alexcrichton
Copy link
Member

Oh right, we're also running near the limit of our capacity right now, so it may be a moment before we can land this unfortunately :(

@alexcrichton
Copy link
Member

Ok so we're currently using 41/45 of our capacity on Travis on each PR. I think we need to leave some breathing room for projects like Cargo/libc and PRs to have capacity as well, so until we get more capacity or shuffle around what we have already I don't think we'll be able to expand our test coverage unfortunately. If we can manage to slot this in somewhere else that'd be great, though!

cc @aturon

@aturon
Copy link
Member

aturon commented Apr 13, 2017

To echo what @alexcrichton is saying: while we can potentially grow our capacity further, we need to figure out a sustainable model going forward as we add an increasing number of platforms; the costs add up quickly. I'll be working with the core team and Mozilla to develop a strategy here, but it will take some time. If we can find other avenues in the meantime, that'd be great.

@japaric
Copy link
Member Author

japaric commented Apr 13, 2017

If we can manage to slot this in somewhere else that'd be great, though!

Do you mean running these tests on an existing builder?

I'm OK with postponing this if there's no capacity atm.

@alexcrichton
Copy link
Member

Yeah if we can get an existing builder to run this and stay under 2hrs then we can land this immediately

@shepmaster shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2017
@shepmaster
Copy link
Member

@japaric do you think you will have time to make the changes to reuse an existing builder?

@shepmaster
Copy link
Member

Thank you for the PR @japaric, but we are going to close this due to a few weeks of inactivity. Please feel free to reopen when you are able to make the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test: cross compiling core for no_std targets
5 participants