Optimize AtomicBool::fetch_nand #41143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The difference between swap and compare_exchange in previous benchmark seemed like something that would be within error, with swap implementation being significantly easier to comprehend. I would r+ if CAS was replaced with swap. |
|
@nagisa Fair enough. Replaced CAS with swap. Yeah, CAS and swap are equally performant according to the benchmarks. |
|
@bors r=nagisa |
|
📌 Commit f7ffe5b has been approved by |
|
⌛ Testing commit f7ffe5b with merge df15b21... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
|
⌛ Testing commit f7ffe5b with merge 9b29afe... |
|
💔 Test failed - status-appveyor |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 7, 2017
…r=nagisa Optimize AtomicBool::fetch_nand This is an attempt to push the PR rust-lang#40563 to completion. Benchmark: [source](https://gist.github.com/stjepang/023f5025623f5474184f9f4dfd6379ae) Improvement: ``` name old_ ns/iter new_ce_ ns/iter diff ns/iter diff % 1t 146,440 89,904 -56,536 -38.61% 2t 561,456 316,835 -244,621 -43.57% 4t 2,822,821 1,005,424 -1,817,397 -64.38% ``` r? @eddyb cc @alexcrichton @nagisa
|
⌛ Testing commit f7ffe5b with merge a05813d... |
|
💔 Test failed - status-appveyor |
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Apr 8, 2017
…r=nagisa Optimize AtomicBool::fetch_nand This is an attempt to push the PR rust-lang#40563 to completion. Benchmark: [source](https://gist.github.com/stjepang/023f5025623f5474184f9f4dfd6379ae) Improvement: ``` name old_ ns/iter new_ce_ ns/iter diff ns/iter diff % 1t 146,440 89,904 -56,536 -38.61% 2t 561,456 316,835 -244,621 -43.57% 4t 2,822,821 1,005,424 -1,817,397 -64.38% ``` r? @eddyb cc @alexcrichton @nagisa
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to push the PR #40563 to completion.
Benchmark: source
Improvement:
r? @eddyb
cc @alexcrichton @nagisa