Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Rollup of 2 pull requests #41283

Merged
merged 4 commits into from
Apr 14, 2017
Merged

[beta] Rollup of 2 pull requests #41283

merged 4 commits into from
Apr 14, 2017

Conversation

frewsxcv
Copy link
Member

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Apr 13, 2017

📌 Commit 3303f0d has been approved by frewsxcv

@frewsxcv frewsxcv changed the title Rollup of 2 pull requests [beta] Rollup of 2 pull requests Apr 13, 2017
@bors
Copy link
Contributor

bors commented Apr 13, 2017

⌛ Testing commit 3303f0d with merge a260f22...

bors added a commit that referenced this pull request Apr 13, 2017
@bors
Auto merge of #41283 - frewsxcv:rollup, r=frewsxcv
a260f22 
[beta] Rollup of 2 pull requests

- Successful merges: #41233, #41274
- Failed merges:
@bors
Copy link
Contributor

bors commented Apr 14, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing a260f22 to beta...

@bors bors merged commit 3303f0d into rust-lang:beta Apr 14, 2017
@bors bors mentioned this pull request Apr 14, 2017
Merged
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frewsxcv @rust-highfive @bors @nikomatsakis @Centril @TimNN