Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote misc #4129

Closed
wants to merge 8 commits into from
Closed

Quote misc #4129

wants to merge 8 commits into from

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Dec 7, 2012

This gets the new token-tree quasiquoter up to the point of being able to stand in for of #ast in the pipe protocol compiler; #ast is only there in #[cfg(stage0)], whereas it's quote_expr! and quote_type! in #[cfg(stage1)] and [#cfg(stage2)]. Also makes the splicing machinery much more robust and extensible (you are allowed to splice anything that implements ToTokens).

While this looks like a lot of sound and noise for nothing, it enables (post-snapshot) cutting out substantial portions of the redundant macro machinery in the frontend. #ast and the quasiquoter is sort of the last thread holding it in place (from last summer).

@ghost ghost assigned brson Dec 7, 2012
@graydon
Copy link
Contributor Author

graydon commented Dec 7, 2012

r? @brson

@brson
Copy link
Contributor

brson commented Dec 7, 2012

Awesome work. r+

@graydon
Copy link
Contributor Author

graydon commented Dec 7, 2012

This landed in bcde593

@graydon graydon closed this Dec 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants