Avoid to use floating point match #41292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Apr 14, 2017
BurntSushi
reviewed
Apr 14, 2017
src/librand/distributions/gamma.rs
Outdated
| _ => Large(GammaLargeShape::new_raw(shape, scale)), | ||
| let repr = if shape == 1.0 { | ||
| One(Exp::new(1.0 / scale)) | ||
| } else if shape > 0.0 && shape < 1.0 { |
There was a problem hiding this comment.
Should this be shape >= 0.0?
(I usually like to write conditions like this with the subject in the middle, e.g., 0.0 <= shape && shape < 1.0, but YMMV.)
Its going to be forbidden, see issue 41255.
|
Addressed the comment. |
|
@bors r+ |
|
📌 Commit baeec7b has been approved by |
|
Thanks @est31! (I haven't forgotten about your other PR btw. I'm really hoping to get to it this weekend!) |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 14, 2017
Avoid to use floating point match Its going to be forbidden, see issue rust-lang#41255.
Mark-Simulacrum
added
the
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its going to be forbidden, see issue #41255.