Run tests for the cargo submodule in tree #41362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
// One of the projects being tested here is Cargo, and when being tested
// Cargo will at some point call `nmake.exe` on Windows MSVC. Unfortunately
// `nmake` will read these two environment variables below and try to
// intepret them. We're likely being run, however, from MSYS `make` which
// uses the same variables.
//
// As a result, to prevent confusion and errors, we remove these variables
// from our environment to prevent passing MSYS make flags to nmake, causing
// it to blow up.
if cfg!(target_env = "msvc") {
env::remove_var("MAKE");
env::remove_var("MAKEFLAGS");
} |
|
Nice catch! Moved over to rustbuild |
alexcrichton
force-pushed
the
run-cargot-ests
branch
from
61c1a89
to
2c9d756
Compare
|
@bors: r+ |
|
📌 Commit 2c9d756 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 19, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
aidanhs
added
the
S-waiting-on-bors
|
⌛ Testing commit 2c9d756 with merge b12057c... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
|
⌛ Testing commit 2c9d756 with merge da63ca9... |
|
⌛ Testing commit 787f98d with merge 33ba984... |
|
💔 Test failed - status-travis |
|
☔ The latest upstream changes (presumably #41464) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
added
S-waiting-on-author
Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
alexcrichton
force-pushed
the
run-cargot-ests
branch
from
787f98d
to
009f45f
Compare
|
@bors: r=aturon |
|
📌 Commit 009f45f has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 24, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 24, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 25, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
arielb1
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 25, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
This was referenced Apr 25, 2017
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
cargotestsuite would run some arbitrary revision of Cargo'stest suite, but now that we're bundling it in tree we should be running the
Cargo submodule's test suite instead.