-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku: fix initial platform support #41456
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! We’ll periodically check in on it to make sure that @pnkfelix or someone else from the team reviews it soon. |
Just found a few more changes I need to make, so not yet ready for merging. |
@jessicah this looks good to me, is it ready to merge? |
@alexcrichton yes, it's ready to merge :) |
@bors: r+ |
📌 Commit 0d63f13 has been approved by |
Will it merge with the checks failed? I had pushed three commits, then undid the last one, so the second commit never got checked. |
Yeah that's ok, @bors will re-check against the latest master once this reaches the head of the queue: https://buildbot2.rust-lang.org/homu/queue/rust |
Haiku: fix initial platform support
Haiku: fix initial platform support
Haiku: fix initial platform support
Haiku: fix initial platform support
Haiku: fix initial platform support
No description provided.