Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #41533

Closed
wants to merge 22 commits into from
Closed

Rollup of 9 pull requests #41533

wants to merge 22 commits into from

Conversation

petrochenkov and others added 22 commits April 16, 2017 21:19
Also spell out that read and write operations should be retried on
`ErrorKind::Interrupted` errors.

Fixes rust-lang#38494.
Turns out all six of these impls are incorrect.
Adds rust-windbg.cmd script

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
Check privacy of trait items in all contexts

Fixes rust-lang#28514

This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
…richton

Add bootstrap support for android
Specify behavior of `write_all` for `ErrorKind::Interrupted` errors

Also spell out that read and write operations should be retried on
`ErrorKind::Interrupted` errors.

Fixes rust-lang#38494.
Add internal accessor methods to io::{Chain, Take}.

Resolves rust-lang#29067.
Step::replace_one should put a one, not a zero (Issue rust-lang#41492)

Turns out all six of the replace_* impls were backwards.
Fix a copy-paste error in `Instant::sub_duration`

Fixes rust-lang#41514.
@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor Author

arielb1 commented Apr 25, 2017

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Apr 25, 2017

📌 Commit a1a19e6 has been approved by arielb1

@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit a1a19e6 with merge 4e30e41...

@bors
Copy link
Contributor

bors commented Apr 25, 2017

💔 Test failed - status-travis

@aidanhs
Copy link
Member

aidanhs commented Apr 25, 2017

Seems like a legit failure

[00:37:25] ---- [compile-fail] compile-fail/trait-item-privacy.rs stdout ----
[00:37:25] 	
[00:37:25] error: /checkout/src/test/compile-fail/trait-item-privacy.rs:86: unexpected "error": '86:19: 86:21: the trait `method::C` cannot be made into an object [E0038]'
[00:37:25] 
[00:37:25] error: /checkout/src/test/compile-fail/trait-item-privacy.rs:88: unexpected "error": '88:7: 88:8: the trait bound `method::C: method::B` is not satisfied [E0277]'
[...]

@arielb1 arielb1 closed this Apr 25, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.